PyPANDA: directory overrides for PANDA constructor #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow caller to specify location of libpanda shared object, pc-bios files, and directory where plugins are installed. If these arguments are left as their default values PyPANDA will use the previous algorithm for finding these files. a773
|
The output from pypanda's test generic_tests.py doesn't look like it's what is expected - I don't think that originated with this PR. |
|
Oh wow yeah, that looks very wrong. Thanks for catching it. Since the test is still marked as passing despite it going off the rails, I'm going to assume that has been broken for a long time and not related to this PR. I'll open an issue. |
|
If there is a chance that PANDA_LIB might cause a problem I could change that to something else. PYPANDA_PANDA_LIB perhaps? |
|
Nah, I think PANDA_LIB is fine - nobody complained so I'll merge this now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PANDA and PyPANDA make some assumptions about where files are installed that don't currently align with how things are done in my environment. I updated both to allow for more fine-grained configuration to be specified. I can rework if there is a better way. Is there anything else I need to do - since this logic is tightly coupled between PyPANDA and PANDA I wasn't sure if anything else needed tweaked (version numbers?)
Allow caller to specify location of libpanda shared object, pc-bios files, and directory where plugins are installed. If these arguments are left as their default values PyPANDA will use the previous algorithm for finding these files.