syscalls2: add multi-abi support #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syscalls
pypanda
lacraig2
force-pushed
the
syscalls2_multi_abi
branch
from
cc777c8
to
14ac93b
Compare
MarkMankins
approved these changes
Oct 22, 2024
| @@ -1324,7 +1378,8 @@ bool init_plugin(void *self) { | |||
|
|
|||
| // load system call info | |||
| if (panda_parse_bool_opt(plugin_args, "load-info", "Load systemcall information for the selected os.")) { | |||
| if (load_syscall_info() < 0) return false; | |||
| printf("load_info\n"); | |||
There was a problem hiding this comment.
Can this be removed or at least wrapped in a call to the standard loggers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1525 by adding the capacity for AARCH64 and X86_64 to call into the code paths for their 32-bit compatible code to parse and handle ABIs other than the original default ABI.
It does so by associating a specific profile that accompanies every syscall. That profile can change either at translate or runtime.
For example, at translate time we can know if an instruction on the X86_64 ISA is actually a backwards compatible
int 0x80instruction and transfer from a PROFILE_LINUX_X64 to a PROFILE_LINUX_X86. In this case we actually call the x86 codepath instead of the x64 codepath.Worth knowing: