Change signature of StringMethods.rsplit to match pandas #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do have tests for |
Dr-Irv
approved these changes
Nov 25, 2024
loicdiridollou
pushed a commit
to loicdiridollou/pandas-stubs
that referenced
this pull request
Nov 27, 2024
Dr-Irv
added a commit
that referenced
this pull request
Nov 27, 2024
* GH1051 Drop astype tests for Mac arm for float128 and complex256 * Fix * Fix * Test fix * Move to macos-latest * Update test.yml * GH1051 Lock in tables version to 3.10.1 * GH1049 Deprecate Index and Grouper methods for 2.0 migration (#1050) * GH1049 Deprecate Index and Grouper methods for migration to 2.0 * GH1049 Deprecate use_nullable_dtypes in read_parquet * Change signature of StringMethods.rsplit to match pandas (#1056) * GH1053 @ for DataFrame, eval in place for DataFrame, test migrations (#1054) * GH1053 @ for DataFrame, eval in place for DataFrame, test migrations * Formatting and spelling * GH1053 PR Feedback * GH1053 Formatting * GH1043 Update _typing.pyi: add "cross" option to JoinHow (#1044) * Update _typing.pyi: add "cross" option to JoinHow * Removed "cross" option from JoinHow and added it back to MergeHow * Replaced JoinHow with MergeHow in frame.join * Added a test for join "how" * Update test_frame.py: used check(assert_type pattern in unit test * Update test_frame.py Fix formatting * Version 2.2.3.241126 --------- Co-authored-by: kroche98 <kroche.md@gmail.com> Co-authored-by: brzegorzTesco <Grzegorz.Bogdal@Tesco.com> Co-authored-by: Irv Lustig <irv@princeton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the nonexistent
regex: boolparameter from theStringMethods.rsplitfunction.pandas.Series.str.rsplit#1032I haven't added any tests, as it doesn't seem the parameter types of any string accessor methods are tested.