type freq in shift, consistently use Frequency alias
#1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoGorelli can you resolve conflicts? |
loicdiridollou
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Can we just confirm that turning str | DateOffset to Frequency is good?
Wondering if there is an edge case for something that is a BaseOffset but not DateOffset.
Otherwise looks good to me, just fix the conflicts, will approve in advance, thanks @MarcoGorelli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frequencyinstead ofstr | BaseOffset/str | DateOffsettimedeltainstead oftimedelta | Timedelta(asTimedeltainherits fromtimedeltaanyway)