Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Improve general datetime functions #352

Merged
merged 15 commits into from
Oct 4, 2022

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Oct 3, 2022

  • Tests added: Please use assert_type() to assert the type of any return value

@bashtage
Copy link
Contributor Author

bashtage commented Oct 3, 2022

Still a few TODOs to verify actual types

@@ -87,23 +92,24 @@ def date_range(
start: str | DatetimeLike | None = ...,
end: str | DatetimeLike | None = ...,
periods: int | None = ...,
# TODO: Test timedelta and Timedelta, update pandas docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are tested, and the docs are updated (I did them).

pandas-stubs/core/indexes/datetimes.pyi Outdated Show resolved Hide resolved
pandas-stubs/core/indexes/datetimes.pyi Outdated Show resolved Hide resolved
pandas-stubs/core/indexes/timedeltas.pyi Show resolved Hide resolved
tests/test_timefuncs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some unresolved stuff from prior comments

pandas-stubs/core/indexes/period.pyi Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bashtage . Good set of tests.

@Dr-Irv Dr-Irv merged commit cb56bfa into pandas-dev:main Oct 4, 2022
@bashtage bashtage deleted the gen-func-datetime branch October 5, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants