Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.11 support #435

Merged
merged 11 commits into from
Nov 24, 2022
Merged

Python 3.11 support #435

merged 11 commits into from
Nov 24, 2022

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Nov 20, 2022 •
edited
Loading

Before merging, awaiting resolution of pandas-dev/pandas#49736 which I hope will get into pandas 1.5.2, and, if so, we can then remove the warning in test_frame.py, otherwise we release with it.

Putting in draft status for now. Should replace PR #398

Pinned pyright to 1.1.279 and 1.1.280 is reporting errors with relative imports
microsoft/pyright#4212

@Dr-Irv Dr-Irv requested a review from bashtage November 20, 2022 04:44
@Dr-Irv Dr-Irv marked this pull request as draft November 20, 2022 04:45
@Dr-Irv Dr-Irv mentioned this pull request Nov 20, 2022
Closed
2 tasks
@Dr-Irv Dr-Irv changed the title Py311 Python 3.11 support Nov 20, 2022
bashtage
bashtage reviewed Nov 20, 2022
View reviewed changes
Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Would be good to explain why the Python version conditional test with a comment.

tests/__init__.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
tests/test_pandas.py Outdated Show resolved Hide resolved
@bashtage
Copy link
Contributor

LGTM. Nightly is just a canary anyway.

bashtage
bashtage approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Dr-Irv Dr-Irv marked this pull request as ready for review November 24, 2022 02:50
@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Nov 24, 2022 •
edited
Loading

@bashtage If you can approve and merge this, then I will do a release.

@jonyscathe
Copy link

I don't know if I should mention this as it might delay this being released slightly.
But now that pyarrow 10.0.1 has been released, I believe that is supposed to have python 3.11 support.

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Nov 24, 2022

I don't know if I should mention this as it might delay this being released slightly. But now that pyarrow 10.0.1 has been released, I believe that is supposed to have python 3.11 support.

Thanks for the heads up. I saw your message in time and have pushed changes for pyarrow support with 3.11

Dr-Irv
Dr-Irv commented Nov 24, 2022
View reviewed changes
.github/setup/action.yaml
@@ -21,7 +21,7 @@ runs:

- name: Determine poetry version
shell: bash
run: echo "::set-output name=VERSION::$(poetry --version)"
run: echo "{VERSION}=$(poetry --version)"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ . We were getting warnings, and this gets rid of them

bashtage
bashtage approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@bashtage bashtage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bashtage bashtage merged commit 9b10f67 into pandas-dev:main Nov 24, 2022
@Dr-Irv Dr-Irv deleted the py311 branch December 28, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandhis1 gandhis1 gandhis1 left review comments

@bashtage bashtage bashtage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.11 support
4 participants
@Dr-Irv @bashtage @jonyscathe @gandhis1