-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH - 624: date_range() now supports a unit keyword "s" , "ms" , "us" , or "ns" #734
GH - 624: date_range() now supports a unit keyword "s" , "ms" , "us" , or "ns" #734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to set up the environment as shown here:
https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md
I think you did not do the pre-commit install
step which would have picked up the issues that the CI found
Still have issues with the pre-commit. See https://github.com/pandas-dev/pandas-stubs/actions/runs/5312915959/jobs/9618117980?pr=734 There's another issue with respect to |
still have the pre-commit issue. Also, there is a bug in pyright 1.1.314. That will be fixed in 1.1.315 that is supposed to be released in a day or two. In the meantime, you can change the line See comment in #729 (comment) |
still have a failing pre-commit test. See https://github.com/pandas-dev/pandas-stubs/actions/runs/5313940150/jobs/9621431339?pr=734 Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @wuyudi
assert_type()
to assert the type of any return value