Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH - 624: date_range() now supports a unit keyword "s" , "ms" , "us" , or "ns" #734

Merged
merged 5 commits into from
Jun 19, 2023
Merged

GH - 624: date_range() now supports a unit keyword "s" , "ms" , "us" , or "ns" #734

merged 5 commits into from
Jun 19, 2023

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Jun 19, 2023

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to set up the environment as shown here:
https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md

I think you did not do the pre-commit install step which would have picked up the issues that the CI found

pandas-stubs/core/indexes/datetimes.pyi Show resolved Hide resolved
tests/test_timefuncs.py Show resolved Hide resolved
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jun 19, 2023

Still have issues with the pre-commit. See https://github.com/pandas-dev/pandas-stubs/actions/runs/5312915959/jobs/9618117980?pr=734

There's another issue with respect to numpy 1.25.0 which we will have to investigate. For now, change the line in pyproject.toml to say numpy = "<=1.24.3" .

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jun 19, 2023

still have the pre-commit issue.

Also, there is a bug in pyright 1.1.314. That will be fixed in 1.1.315 that is supposed to be released in a day or two. In the meantime, you can change the line pyright = ">= 1.1.310" to `pyright = "<= 1.1.313" .

See comment in #729 (comment)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jun 19, 2023

still have a failing pre-commit test. See https://github.com/pandas-dev/pandas-stubs/actions/runs/5313940150/jobs/9621431339?pr=734

Please run pre-commit install in your environment and then do black pandas-stubs

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @wuyudi

@Dr-Irv Dr-Irv merged commit 6fe90bb into pandas-dev:main Jun 19, 2023
@asukaminato0721 asukaminato0721 deleted the date_range-new-keyword branch November 4, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.0 Compatibility Tracker
2 participants