Skip to content

Added types to df.info() #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2024
Merged

Added types to df.info() #875

merged 1 commit into from
Feb 23, 2024

Conversation

askmyhat
Copy link
Contributor

No description provided.

twoertwein
twoertwein reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case, something like:

check(assert_type(df.info(show_counts=True), None), None)
check(assert_type(df.info(show_counts=None), None), None)

@askmyhat askmyhat changed the title Replaced null_counts with show_counts in df.info() Added types to df.info() Feb 22, 2024
@twoertwein twoertwein requested a review from Dr-Irv February 22, 2024 19:42
Dr-Irv
Dr-Irv requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

@askmyhat askmyhat requested a review from Dr-Irv February 23, 2024 17:18
Dr-Irv
Dr-Irv approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @askmyhat

@Dr-Irv Dr-Irv merged commit 02abbdb into pandas-dev:main Feb 23, 2024
@Dr-Irv Dr-Irv mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

+1 more reviewer

@twoertwein twoertwein twoertwein left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@askmyhat @twoertwein @Dr-Irv