-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
to_json converts to UTC when encoding ISO formatted datetimes #12997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Komnomnomnom is this an option that you want to add? (e.g. the |
|
ahh ok, so its a bug. ok then! |
Sorry I should have been more clear in the description :) |
@Komnomnomnom np! no pressure on fixing this one for 0.18.1. Can be in the next version. |
any milestone for this feature ? currently, need to convert datetime to str before exporting to json and feed plotly charts... |
No specific milestone, but contributions are welcome! |
Any updates? |
@jeliashi you or others from the community are welcome to submit a patch |
seems like just updating the files that are copied from numpy ( If I have time, I can tackle, but maybe someone else wants to do so before me |
So I made a PR to fix this #41573 that tries to mimic what the numpy library does. I've been thinking about this a lot lately and was wondering if it would make more sense to move away from the numpy library way to do it. They use the C interface to call the pytz objects directly which is what I am doing in this PR. But I don't have to do it their way. They use their pytz objects to calculate new datetime objects in utc time which they then use to calculate differences in minuted between UTC and their local time. However, I was thinking instead we could use the datetime object directly to create the strings within the C interface. |
Code Sample
Expected Output
cf
The text was updated successfully, but these errors were encountered: