-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: remove datareader docs #13724
Comments
+1 on removing doc here |
I would remove code as well. but docs at the very least. |
What we could do is remove the code (and tests), but still include the file to raise a more informative ImportError (the current deprecation warning, but as an error). |
Or import corresponding |
We had that discussion at the time of deprecation as well. Personally, I am not a fan of that (keeping the pandas imports but implicitly use the import datareader package). Users should just know it is another and separate package, and if they already have installed it, they should just change their imports |
I would just raise |
io.data
andio.web
have been deprecated since 0.17 and moved to thepandas-datareader
project. I am not necessarily saying we should already remove the code (although we could, certainly given that the tests cause failures from time to time, but we can also wait until 0.20), but my proposal is to already remove the docs (and only include a link to the pandas-datareader docs).Reason: some of the examples are failing anyways (due to issues with yahoo), our docs already take quite a while to build, and the exact same content is available in the pandas-datareader docs.
Any objections?
@jreback @davidastephens @sinhrks @femtotrader
The text was updated successfully, but these errors were encountered: