Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: remove datareader docs #13724

Closed
jorisvandenbossche opened this issue Jul 20, 2016 · 6 comments
Closed

DOC: remove datareader docs #13724

jorisvandenbossche opened this issue Jul 20, 2016 · 6 comments
Milestone

Comments

@jorisvandenbossche
Copy link
Member

io.data and io.web have been deprecated since 0.17 and moved to the pandas-datareader project. I am not necessarily saying we should already remove the code (although we could, certainly given that the tests cause failures from time to time, but we can also wait until 0.20), but my proposal is to already remove the docs (and only include a link to the pandas-datareader docs).

Reason: some of the examples are failing anyways (due to issues with yahoo), our docs already take quite a while to build, and the exact same content is available in the pandas-datareader docs.

Any objections?

@jreback @davidastephens @sinhrks @femtotrader

@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Jul 20, 2016
@femtotrader
Copy link

+1 on removing doc here
I'm not against removing code also.

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

I would remove code as well. but docs at the very least.

@jorisvandenbossche
Copy link
Member Author

What we could do is remove the code (and tests), but still include the file to raise a more informative ImportError (the current deprecation warning, but as an error).

@sinhrks
Copy link
Member

sinhrks commented Jul 20, 2016

Or import corresponding data_reader namespace if installed (with warning).

@jorisvandenbossche
Copy link
Member Author

We had that discussion at the time of deprecation as well. Personally, I am not a fan of that (keeping the pandas imports but implicitly use the import datareader package). Users should just know it is another and separate package, and if they already have installed it, they should just change their imports

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

I would just raise
automagically substituting a package is not good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants