Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: private impl of OrderedDefaultDict can be removed #16668

Closed
jreback opened this issue Jun 11, 2017 · 3 comments · Fixed by #16939
Closed

CLN: private impl of OrderedDefaultDict can be removed #16668

jreback opened this issue Jun 11, 2017 · 3 comments · Fixed by #16939
Labels
Clean
Milestone
0.21.0

Comments

@jreback
Copy link
Contributor

jreback commented Jun 11, 2017

https://github.com/pandas-dev/pandas/blob/master/pandas/compat/__init__.py#L376

I think this was leftover from 2.6 compat.
@jreback jreback added this to the Next Major Release milestone Jun 11, 2017
@rosygupta
Copy link

@jreback So the private methods need to be made public? Is that all is required?

@jreback
Copy link
Contributor Author

jreback commented Jun 11, 2017

no i think it can just be removed

@TomAugspurger
Copy link
Contributor

And replaced with an import from collections import OrderedDict.

@faic faic mentioned this issue Jul 15, 2017
Merged
4 tasks
@jreback jreback modified the milestones: 0.21.0, Next Major Release Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

CLN16668: remove OrderedDefaultDict faic/pandas
3 participants
@jreback @TomAugspurger @rosygupta