Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: test_intersect_str_dates appears to have been mistakenly placed in tests/indexes/test_range.py #17362

Closed
jschendel opened this issue Aug 28, 2017 · 3 comments · Fixed by #17366
Labels
Clean Testing pandas testing functions or related to the test suite
Milestone

Comments

@jschendel
Copy link
Member

Code Sample, a copy-pastable example if possible

def test_intersect_str_dates(self):
dt_dates = [datetime(2012, 2, 9), datetime(2012, 2, 22)]
i1 = Index(dt_dates, dtype=object)
i2 = Index(['aa'], dtype=object)
res = i2.intersection(i1)
assert len(res) == 0

Problem description

The test_intersect_str_dates test within tests/indexes/test_range.py doesn't appear to have anything to do with RangeIndex. It seems like this should be moved to tests/indexes/test_base.py? Happy to submit a PR if this is the case.

@gfyoung gfyoung added Clean Testing pandas testing functions or related to the test suite labels Aug 28, 2017
@gfyoung
Copy link
Member

gfyoung commented Aug 28, 2017

That seems like a pretty good home for it. BTW, for reference, you probably could just have submitted a PR directly, as this is relatively trivial.

@jschendel
Copy link
Member Author

Okay, will omit creating an issue for trivial stuff like this in the future. Need to get my brain out of "every PR needs a corresponding issue" mode 😆

@gfyoung
Copy link
Member

gfyoung commented Aug 28, 2017

No worries! I'm just saying this to make your life a little easier (or rather, to streamline the process for you to contribute). We won't get mad if you follow the standard issue --> PR format. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants