-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
localize_tso unnecessary calls? #17944
Comments
@jbrockmendel : There's one way to find out: remove the calls and run the tests 😄 |
Doesn't cause any test failures; kind of hoping for outside confirmation though. |
This can be fixed in a follow-up after #17875 is closed |
jreback
pushed a commit
that referenced
this issue
Nov 12, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this issue
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related: #17876, #17734
In
tslib._localize_tso
there are 4 of blocks of the form:But in the case where
obj.value == NPY_NAT
, can't we skip the call topandas_datetime_to_datetimestruct
because we're going to end up withNaT
anyway?The text was updated successfully, but these errors were encountered: