Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: add asv job to travis #19104

Closed
jreback opened this issue Jan 6, 2018 · 3 comments
Closed

PERF: add asv job to travis #19104

jreback opened this issue Jan 6, 2018 · 3 comments
Labels
Performance Memory or execution speed performance

Comments

@jreback
Copy link
Contributor

jreback commented Jan 6, 2018

The purpose is to check that all of the asv jobs are running w/o error. So modifications can be caught at PR time. I think this will be possible using asv dev rather than trying to compare commits. This could be added onto an existing job I think (so we don't have to build again).

It also might be possible to add a travis job to actually build and compare both environments, this might be possible, again I dont' know if this would take too much time and/or be too flaky. This is not meant to replace our offline benchmarks rather to catch regressions sooner.

@jreback jreback added Difficulty Intermediate Performance Memory or execution speed performance labels Jan 6, 2018
@jreback jreback added this to the Next Major Release milestone Jan 6, 2018
@jreback
Copy link
Contributor Author

jreback commented Jan 6, 2018

cc @mroeschke
@TomAugspurger

@mroeschke
Copy link
Member

xref #15035 for running and comparing full asv benchmarks on Travis

But agreed, should be possible to run asv run --quick and raise a lint error if a benchmark returns "failed"

@jreback
Copy link
Contributor Author

jreback commented Jan 9, 2018

ahh yes thought we had an issue about this ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

No branches or pull requests

2 participants