Release notes don't warn/inform about skip_footer changes

[gerigk]

This change ( before, skipping the last row was skip_footer=1, now this is accomplished by skip_footer=-1, otherwise you will only receive one row) should be announced clearly in the release notes imho.

[wesm]

I wasn't aware of this API change. @changhiskhan?

Sent from my mobile device

On Sep 22, 2012, at 1:06 PM, Arthur Gerigk notifications@github.com wrote:

This change ( before, skipping the last row was skip_footer=1, now this is
accomplished by skip_footer=-1, otherwise you will only receive one row)
should be announced clearly in the release notes imho.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/1948.

[gerigk]

skip_footer : int, default 0
Lines at bottom of file to skip. If >0 then indicates the row to start
skipping. If <0 then skips the specified number of rows from the end.

from the current doc string. I can confirm the behaviour since it crashed my tests ;)

[changhiskhan]

@gerigk sorry about that. Think of skip_footer as keep rows 0:N
When parsing Excel sheets, some times you know which row you want to stop parsing at and some times you know how many rows at the end to through away. And we didn't want to add an additional parameter.
We'll make a decision whether to stick with the old API or not but if there is API change it will be in the release notes before 0.9 final.

[wesm]

One option is to revert the API and instruct users who want 0:N to use the
nrows argument

Sent from my mobile device

On Sep 24, 2012, at 1:35 AM, Chang She notifications@github.com wrote:

@gerigk https://github.com/gerigk sorry about that. Think of skip_footer
as keep rows 0:N
When parsing Excel sheets, some times you know which row you want to stop
parsing at and some times you know how many rows at the end to through
away. And we didn't want to add an additional parameter.
We'll make a decision whether to stick with the old API or not but if there
is API change it will be in the release notes before 0.9 final.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/1948#issuecomment-8807905.

[changhiskhan]

oh duh, that should work fine actually

[gerigk]

slightly unrelated: what about unifying skiprows and skip_footer to either
no underscore or both with an underscore?
one could use a deprecation message for transition.

On Mon, Sep 24, 2012 at 2:05 PM, Chang She notifications@github.com wrote:

oh duh, that should work fine actually

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1948#issuecomment-8816555.

[changhiskhan]

The API change was reverted. skip_footer is now exposed for ExcelFile.parse as well and skipfooter is aliased to skip_footer now.