Classes should maintain a registry of accessors

[TomAugspurger]

Dask would like to inherit the accessors registered by register_*_acessor. This would be much easier if the regiser_*_accessor methods added the name of the accessor to a (private) class variable.

It seems like we have use of it in pandas as well: https://github.com/pandas-dev/pandas/pull/19960/files#r171815351

[WillAyd]

I could be coming way out of left field on this one but were metaclasses ever given consideration for the accessors? It seems like using them instead of decorators would still allow you to register the methods you need on a subclass, but at the same time give give you access to that registered metadata without having to store it in a private variable in the subclass

[TomAugspurger]

I think storing the registry as a private var on the class having the accessor attached strikes a nice balance between simplicity and usability.

…

On Fri, Mar 30, 2018 at 3:38 AM, William Ayd ***@***.***> wrote: I could be coming way out of left field on this one but were metaclasses ever given consideration for the accessors? It seems like using them instead of decorators would still allow you to register the methods you need on a subclass, but at the same time give give you access to that registered metadata without having to store it in a private variable in the subclass — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19963 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIn4bGrzqU4MGI46_4JFNpsAN2Fb1ks5tje78gaJpZM4SZ0nm> .