Skip to content

Dtype checking in reshape.merge #23929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Nov 26, 2018 · 0 comments
Closed

Dtype checking in reshape.merge #23929

jbrockmendel opened this issue Nov 26, 2018 · 0 comments
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Comments

@jbrockmendel
Copy link
Member

There is a check (equivalent to)

elif (issubclass(lk.dtype.type, (np.integer, np.timedelta64, np.datetime64)) and
      issubclass(rk.dtype.type, (np.integer, np.timedelta64, np.datetime64))):

which I'm told is incorrect:

this is not right, these should be in separate branches here, the datetime / timedeltas can be in a single elif clause.

#23917 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @mroeschke