Skip to content

DEPR: copy argument in DataFrame/Series.tz_localize/tz_convert #24667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mroeschke opened this issue Jan 8, 2019 · 5 comments
Closed

DEPR: copy argument in DataFrame/Series.tz_localize/tz_convert #24667

mroeschke opened this issue Jan 8, 2019 · 5 comments
Labels
Closing Candidate May be closeable, needs more eyeballs Deprecate Functionality to remove in pandas Timezones Timezone data dtype

Comments

@mroeschke
Copy link
Member

ref: #24657 (comment)

The copy argument in these methods should be deprecated in favor of inplace to be consistent with other methods.

@mroeschke mroeschke added Timezones Timezone data dtype Deprecate Functionality to remove in pandas labels Jan 8, 2019
@jorisvandenbossche
Copy link
Member

Whether we want to do this or not might depend on the discussion in #16529

@jbrockmendel
Copy link
Member

the future of 'copy' depends on CoW, but i think we're agreed against implementing more inplace keywords. closeable?

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Sep 16, 2022
@mroeschke
Copy link
Member Author

Yeah agreed that probably shouldn't be replaced with inplace but copy here should get the same treatment as your similar PRs for methods that only effect the index?

@jbrockmendel
Copy link
Member

but copy here should get the same treatment as your similar PRs for methods that only effect the index?

Not sure what you mean. tz_convert/tz_localize already make shallow copies when copy=False

@mroeschke
Copy link
Member Author

Ah gotcha. Nonetheless your original point stands as copy should be kept in favor of inplace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closing Candidate May be closeable, needs more eyeballs Deprecate Functionality to remove in pandas Timezones Timezone data dtype
Projects
None yet
Development

No branches or pull requests

3 participants