CategoricalAccessor.categorical removed in 0.24.0rc1

[TomAugspurger]

Previously, CategoricalAccessor set .categorical in __init__. I don't think this was intended to be the way to access things like .ordered, but it wasn't prefixed with an underscore, so we should deprecate before removing

0.23.4

In [11]: pd.Series(['a', 'b'], dtype='category').cat.categorical.ordered
Out[11]: False

0.24.0rc1

In [3]: pd.Series(['a', 'b'], dtype='category').cat.categorical.ordered
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-3-e5c7f0300480> in <module>
----> 1 pd.Series(['a', 'b'], dtype='category').cat.categorical.ordered

AttributeError: 'CategoricalAccessor' object has no attribute 'categorical'

We can deprecate with

def categorical(self):
    warnings.warn(...)
    return self._parent

in

pandas/pandas/core/arrays/categorical.py

Line 2472 in 33f91d8

class CategoricalAccessor(PandasDelegate, PandasObject, NoNewAttributesMixin):

We should do the same for .index and .name.

[benjaminr]

Will take a look at this one.

[jreback]

I am not sure we need to deprecate this at all. This is a non-public interface to begin with (and not in-line with anything else in pandas).

[TomAugspurger]

It wasn't prefixed with an underscore.

…

On Sun, Jan 13, 2019 at 3:27 PM Jeff Reback ***@***.***> wrote: I am not sure we need to deprecate this at all. This is a non-public interface to begin with (and not in-line with anything else in pandas). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24751 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHItllU5Hi3G1qp2aeg4thfT1g_j5aks5vC6TSgaJpZM4Z9RPT> .

[jreback]

It wasn't prefixed with an underscore.

lots of things are not prefixed with underscored. .categoricals is not a valid construction, nor was this ever advertised / documented. This is taking deprecations too far.

[TomAugspurger]

We made a mistake and the data was made public. We need a deprecation.

…

________________________________ From: Jeff Reback <notifications@github.com> Sent: Sunday, January 13, 2019 15:41 To: pandas-dev/pandas Cc: Tom Augspurger; Author Subject: Re: [pandas-dev/pandas] CategoricalAccessor.categorical removed in 0.24.0rc1 (#24751) It wasn't prefixed with an underscore. lots of things are not prefixed with underscored. .categoricals is not a valid construction, nor was this ever advertised / documented. This is taking deprecations too far. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#24751 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIvgcgoLFPoKzmUIXvdkg3FG4PC6uks5vC6gBgaJpZM4Z9RPT>.

[jreback]

@TomAugspurger not convinced, we havemany places where you can access attributes; and we have changed any of these. This is a very very minor case. I don't think the deprecation is worth it.

[TomAugspurger]

I think it is.

…

________________________________ From: Jeff Reback <notifications@github.com> Sent: Sunday, January 13, 2019 16:40 To: pandas-dev/pandas Cc: Tom Augspurger; Mention Subject: Re: [pandas-dev/pandas] CategoricalAccessor.categorical removed in 0.24.0rc1 (#24751) @TomAugspurger<https://github.com/TomAugspurger> not convinced, we havemany places where you can access attributes; and we have changed any of these. This is a very very minor case. I don't think the deprecation is worth it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#24751 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIhyuZsVVkfY0iztkFDhFMcX910-4ks5vC7XhgaJpZM4Z9RPT>.

[jorisvandenbossche]

It is very simple to deprecate it (it's not adding complexity to the non-deprecated code), so let's just do it.

@benjaminr can you re-open your PR?

[benjaminr]

@jorisvandenbossche sure thing 👍