-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compat: re-write legacy files for io tests #25250
Comments
Unless we plan to explicitly drop support for older files, I don't think all of them should be rewritten. Most of them sure, but we should leave a couple of tests to ensure backwards compatibility of some sort. |
the idea is to rewrite them with the older version of pandas but with the generate from master this ensures that Panels are not written but ensures backward compat |
AFAICT this is a blocker for removing Panel. I was unable to find a way to patch the pickle tests to not raise if Panel does not exist. |
Just so I'm clear on expectation we don't need to go back and change all of the historical pickle files do we? We have some of these going back to 0.10.1 - I'm assuming older ones we can just let be historical artifacts? Do we just now need one file per OS? |
I think the idea is to re-write the historical ones using old pandas but up-to-date generate_files_whatever.py (For orthogonal reasons I'd be +1 on trimming how many old versions we support for pickle compat) |
closed by #27082 |
#25238 introduced a kludge in test_pickle and test_msgpack to ignore the Panel objects when unpickling/unpacking files produced using older versions. The right way to do this is to re-write those files without Panels in them to begin with.
The text was updated successfully, but these errors were encountered: