Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Revert internal CategoricalDtype.ordered -> CategoricalDtype._ordered references #27203

Closed
jschendel opened this issue Jul 3, 2019 · 2 comments · Fixed by #29955
Closed

CLN: Revert internal CategoricalDtype.ordered -> CategoricalDtype._ordered references #27203

jschendel opened this issue Jul 3, 2019 · 2 comments · Fixed by #29955
Assignees
@jschendel
Labels
Categorical Categorical Data Type Clean Code Style Code style, linting, code_checks
Milestone
1.0.0

Comments

@jschendel
Copy link
Member

xref #26403 (comment)

This will need to be done as part of the process for changing the default value of CategoricalDtype.ordered from None to False, which should be part of the 1.0 release. Opening this issue to serve as a reminder.
@jschendel jschendel added Categorical Categorical Data Type Code Style Code style, linting, code_checks Clean labels Jul 3, 2019
@jschendel jschendel added this to the 1.0 milestone Jul 3, 2019
@jschendel jschendel self-assigned this Jul 3, 2019
@TomAugspurger
Copy link
Contributor

@jschendel are you likely to have time for this for 1.0?

@jschendel
Copy link
Member Author

Yes, I can do this for 1.0

@jschendel jschendel mentioned this issue Dec 2, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jschendel jschendel

Labels
Categorical Categorical Data Type Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

DEPR: Change default value for CategoricalDtype.ordered from None to False jschendel/pandas
2 participants
@TomAugspurger @jschendel