Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NumPy Stubs #27589

Closed
WillAyd opened this issue Jul 25, 2019 · 3 comments
Closed

Add NumPy Stubs #27589

WillAyd opened this issue Jul 25, 2019 · 3 comments
Labels
Dependencies Required and optional dependencies Needs Discussion Requires discussion from core team before further action

Comments

@WillAyd
Copy link
Member

WillAyd commented Jul 25, 2019

We use ndarray often in our annotations, but it always just resolves to Any since it doesn't have any annotations natively. It looks like numpy has a separate Numpy-stubs repo under development:

https://github.com/numpy/numpy-stubs

Might be worth considering that as a development dependency. Certainly would like to find issues with ndarray usage sooner than later

@shoyer

@WillAyd WillAyd added Needs Discussion Requires discussion from core team before further action Dependencies Required and optional dependencies labels Jul 25, 2019
@jbrockmendel
Copy link
Member

MIght be a pipedream, but it would be nice if we could have numpy annotations consistent with the existing cython syntax, e.g. ndarray[np.float64, ndim=1]. Both for the consistency and the specificity.

@shoyer
Copy link
Member

shoyer commented Jul 29, 2019 via email

@simonjayhawkins
Copy link
Member

@WillAyd With numpy types imminent, I think we can now close this issue. feel free to reopen if disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Needs Discussion Requires discussion from core team before further action
Projects
None yet
Development

No branches or pull requests

4 participants