RLS: 0.25.2

[TomAugspurger]

cc @pandas-dev/pandas-core

Python 3.8 is due on October 21, which will likely beat 1.0.

We should release a 0.25.2 around then that's just 0.25.1 + 3.8 compatibility and regressions from 0.24.x.

[jorisvandenbossche]

I don't think we need to wait until then? (the sooner it is already out, the less people will have issues when updating to 3.8)
So I would just continue backporting regressions (but we can be conservative in backporting, no need to backport normal bug fixes), and we can always see when we have accumulated some fixes.

[TomAugspurger]

Yeah, that's just the deadline.

We'll also need to handle building 3.8 binaries after the release. I think that should be doable (just bump the build number on conda-forge when they're ready, and upload only the 3.8 wheels from multibuild).

[stonebig]

shouldn't a bug fix be released with Python-3.8.0rc1 (sept 30th), so that users trying Python-3.8.0rc can look for un-solved bugs only ?

[TomAugspurger]

The earlier the better probably. We need to get things running on our CI first though.

[TomAugspurger]

FYI, @jbrockmendel and I may try to knock out a release this week while we're in town together (likely on Thursday). Ideally we'll be able to get a bit of CI coverage on 3.8 before then.

[jreback]

is conda-forge any better at 3.8 now?

[TomAugspurger]

No, not yet.

…

On Tue, Oct 1, 2019 at 7:23 AM Jeff Reback ***@***.***> wrote: is conda-forge any better at 3.8 now? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#28110?email_source=notifications&email_token=AAKAOIRG7Y77BUSFSD2KVEDQMM6LJA5CNFSM4IO6ZMV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEABCHWY#issuecomment-537011163>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIQ5V4BNHC5RYGVMFVLQMM6LJANCNFSM4IO6ZMVQ> .

[TomAugspurger]

3.8 is out now. @jbrockmendel are you free to do a release tomorrow?

I think the remaining prep work is just to clean up the v0.25.2.rst whatsnew (spell check, add a release date, general cleanup) on master and backport

[TomAugspurger]

The 0.25.x branch should be almost ready.

We have

• Backport PR #28730 on branch 0.25.x (CI: 3.8 build) #29002
• Backport PR #28982 on branch 0.25.x (Document 3.8 compatibility) #28999
• DOC: 0.25.2 whatsnew cleanup #29000 (+ backport)

then I think we're ready.

I can't actually do the release this time around. My main laptop is being serviced, and I don't think the machine I'm on can physically run docker. Hopefully @jbrockmendel is able to today (I'll be around to assist). @jbrockmendel can you confirm that you're jbrockmendel on PyPI? @jreback can you add him as a maintainer on PyPI when he's done so?

[TomAugspurger]

3.8 Binaries

In MacPython/pandas-wheels#64, we're testing our wheel infrastructure on 0.25.x with 3.8. I have two questions

1. What version of NumPy can / should those be built against? @rgommers @matthew-brett do you have recommendations? I assumed I needed 1.18.0.dev0, since that's the first NumPy to be compatible with Python 3.8. Is building wheels to be published on PyPI against a dev version of NumPy a bad idea? We can wait to build / upload 3.8 wheels until later.
2. @cgohlke are you set up for building 3.8 wheels? What version of NumPy will you build those against?

Conda-forge is working on 3.8 packages. Those will likely take a bit longer.

[rgommers]

Is building wheels to be published on PyPI against a dev version of NumPy a bad idea? We can wait to build / upload 3.8 wheels until later.

Yes I think that's not the best idea. @charris is planning to release a Python 3.8 compatible NumPy 1.17.3 shortly, so that's a much better target. Wheels built against 1.18.0.dev0 likely won't work with 1.17.3.

[TomAugspurger]

Ah, good to know about the 1.17.3 release. I'll keep my eye on numpy/numpy#14698. We can hold off on releasing 0.25.2 until those are ready.