Skip to content

Is @td.skip_if_no("pathlib") necessary? #30375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Dec 20, 2019 · 2 comments · Fixed by #30376
Closed

Is @td.skip_if_no("pathlib") necessary? #30375

MarcoGorelli opened this issue Dec 20, 2019 · 2 comments · Fixed by #30376
Labels
Clean

Comments

@MarcoGorelli
Copy link
Member

Admittely this is very minor, but
there's a few parts in the codebase (e.g. pandas/tests/io/test_common.py) where there is

@td.skip_if_no("pathlib")

As of v1.0, the minimum Python version supported will be 3.6.1, so pathlib will always be present as part of the standard library.
@TomAugspurger
Copy link
Contributor

No necessary anymore, it can be removed.

@TomAugspurger TomAugspurger added this to the Contributions Welcome milestone Dec 20, 2019
@Ynob2000 Ynob2000 mentioned this issue Dec 20, 2019
Closed
5 tasks
@MarcoGorelli MarcoGorelli mentioned this issue Dec 20, 2019
Merged
5 tasks
@jreback
Copy link
Contributor

jreback commented Dec 20, 2019

closed by #30376

@jreback jreback closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
No milestone
3 participants
@jreback @TomAugspurger @MarcoGorelli