Skip to content

CI: azure pipelines are not in PRS #32705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Mar 14, 2020 · 12 comments · Fixed by #32706
Closed

CI: azure pipelines are not in PRS #32705

jreback opened this issue Mar 14, 2020 · 12 comments · Fixed by #32706
Labels
CI Continuous Integration
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

cc @pandas-dev/pandas-core

@jreback jreback added the CI Continuous Integration label Mar 14, 2020
@jreback jreback added this to the 1.1 milestone Mar 14, 2020
@jreback
Copy link
Contributor Author

jreback commented Mar 14, 2020

last run on thursday: https://dev.azure.com/pandas-dev/pandas/_build

@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2020

Any chance something shows wrong with our plan on the plugin?

https://github.com/marketplace/azure-pipelines

I don't see anything for pandas on that, but maybe an access thing

@jreback
Copy link
Contributor Author

jreback commented Mar 14, 2020

i deselected and reselected the plugin, let's see

@jreback
Copy link
Contributor Author

jreback commented Mar 14, 2020

ok was able to run on master (its queued). let's see

@jreback
Copy link
Contributor Author

jreback commented Mar 14, 2020

#32697 just triggered, so let's see

@datapythonista
Copy link
Member

I read on twitter that @seanlaw had problems with this yesterday, I guess it's an issue in Azure: https://twitter.com/seanmylaw/status/1238526293207023617

@vtbassmatt @chrispat do you know what's the problem on pipelines not starting for pull requests?

@jreback
Copy link
Contributor Author

jreback commented Mar 14, 2020

yeah so a manual runs seems to work, but its not triggering.

@seanlaw
Copy link
Contributor

seanlaw commented Mar 14, 2020

@datapythonista @jreback Not sure what you have inside of your azure-pipelines.yml but I ended up needing to explicitly add a PR trigger:

trigger:
- master

pr:
- master

Previous to yesterday, it was enough to trigger CI with only:

trigger:
- master

I just checked my own repo and submitted a PR and it triggered properly. Something must've changed on Azure. Hope this helps.

@datapythonista
Copy link
Member

Thanks for the info @seanlaw, let's give it a try (we didn't have any of these options).

@datapythonista
Copy link
Member

Yep, looks like adding these pipelines is triggered, thanks!

@seanlaw
Copy link
Contributor

seanlaw commented Mar 14, 2020

Glad it worked out!

Not sure if I'm the only one who failed to read the docs but I also learned from the Azure folks yesterday that you can trigger pipeline runs by commenting directly on PRs: /azp run

@datapythonista
Copy link
Member

Not sure if I'm the only one who failed to read the docs but I also learned from the Azure folks yesterday that you can trigger pipeline runs by commenting directly on PRs: /azp run

That's very useful to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants