Skip to content

CI: Update pipelines config to trigger on PRs #32706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2020
Merged

CI: Update pipelines config to trigger on PRs #32706

merged 1 commit into from
Mar 14, 2020

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista added the CI Continuous Integration label Mar 14, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2020

Thanks for this! Not sure what is up with the failure - just restarted let's see...

- master

pr:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know of a way to just do this for all PRs? I have a hunch that this wouldn't run now for backports but didn't see anything in the docs:

https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=example%2Cparameter-schema#pr-trigger

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just need to specify as *:

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=azure-devops&tabs=yaml#wildcards

Though I think it's a bug that we need this in the first place given this in the docs:

A pull request trigger specifies which branches cause a pull request build to run. If you specify no pull request trigger, pull requests to any branch trigger a build

@jreback jreback added this to the 1.1 milestone Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

hmm, is the 32-bit build borked? we can just merge this and followup if needed later.

@jreback jreback merged commit 427af4d into pandas-dev:master Mar 14, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 14, 2020

Yea I guess need a follow up to get rid of the 32 bit one though; looks to be failing

@WillAyd WillAyd mentioned this pull request Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

@TomAugspurger marking for 1.0.3 if needed

@simonjayhawkins
Copy link
Member

This is marked as still needs manual backport. looking at the code changes there is reference to master. What needs to be done here?

@datapythonista
Copy link
Member Author

Not sure, I guess if we want to run the CI on other branches, the name of the branch (master in the diff) should be updated for each branch.

For context, without these changes, pipelines wasn't running.

@simonjayhawkins
Copy link
Member

For context, without these changes, pipelines wasn't running.

the azure jobs are running on 1.0.x, its the code checks that are not running

@simonjayhawkins
Copy link
Member

i've removed the needs manual backport, but will probably resurface after 1.1.0 is released.

@simonjayhawkins
Copy link
Member

i've removed the needs manual backport, but will probably resurface after 1.1.0 is released.

cc @TomAugspurger

@simonjayhawkins
Copy link
Member

I think needs to be changed in master so that when the 1.1.x branch is created, backport PRs will be checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: azure pipelines are not in PRS
4 participants