-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Update pipelines config to trigger on PRs #32706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
datapythonista
commented
Mar 14, 2020
- closes CI: azure pipelines are not in PRS #32705
Thanks for this! Not sure what is up with the failure - just restarted let's see... |
- master | ||
|
||
pr: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know of a way to just do this for all PRs? I have a hunch that this wouldn't run now for backports but didn't see anything in the docs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just need to specify as *:
Though I think it's a bug that we need this in the first place given this in the docs:
A pull request trigger specifies which branches cause a pull request build to run. If you specify no pull request trigger, pull requests to any branch trigger a build
hmm, is the 32-bit build borked? we can just merge this and followup if needed later. |
Yea I guess need a follow up to get rid of the 32 bit one though; looks to be failing |
@TomAugspurger marking for 1.0.3 if needed |
This is marked as still needs manual backport. looking at the code changes there is reference to master. What needs to be done here? |
Not sure, I guess if we want to run the CI on other branches, the name of the branch ( For context, without these changes, pipelines wasn't running. |
the azure jobs are running on 1.0.x, its the code checks that are not running |
i've removed the needs manual backport, but will probably resurface after 1.1.0 is released. |
|
I think needs to be changed in master so that when the 1.1.x branch is created, backport PRs will be checked |