-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility issues with master branch cython #33224
Comments
Thanks for the report. The Werror flag is new on our end so still a few kinks to work out What platform / python version are you using? |
arch linux. I saw this with both py38 and cpython master. It compiles without warnings with cython 0.29 for both py38 and py39. |
xref @jbrockmendel issues in #30609 (comment) |
Can you attach the cythonized file? May be helpful to trace back to the code base |
There are definitely more errors, requested output below. It won't let me attach a .c file (and it is 166k LoC), if you want the cythonized files it is probably easiest for you to install cython from source locally (
|
@tacaswell Thank you! |
AFAICT the common denominator between all of the offending functions is that they mix together a fused type with a memoryview along with the boundscheck / wraparound decorators set to False pandas/pandas/_libs/writers.pyx Line 121 in e79dc5f
pandas/pandas/_libs/reshape.pyx Line 39 in e79dc5f
pandas/pandas/_libs/groupby.pyx Line 1453 in e79dc5f
Line 1211 in e79dc5f
|
@WillAyd here is This have the following warnings:
Cython source used: https://github.com/cython/cython/tree/e9d7fd45a2e829ee93980b1c0612f8476a46431d Algos source: https://github.com/pandas-dev/pandas/blob/1d86861681d0d4046f3d391f641c8bdfd86eb61d/pandas/_libs/algos.pyx |
@tacaswell Github will only allow [GIF, JPEG, JPG, PNG, DOCX, GZ, LOG, PDF, PPTX, TXT, XLSX, ZIP] files. One quick around is just to rename the file extension ;) |
@WillAyd I just tried Cython with the latest version https://github.com/cython/cython/tree/30c891e0dc36a553455df9064ecb1f13414a12d2 And pandas still have some errors for example in
Would you like me to upload the full log file, as well any files that have errors in them? |
Those don't appear the same as the OP so probably a separate issue. Try cleaning your environment, then rebuilding and if it persists open a new issue |
I have ran
So I'll open a new issue. |
On the cython master branch the generated c code has unused functions which fails the build with:
and similar warnings from other modules (this just happens to be the first one).
If I remove the
"-Werror"
it seems to build ok.Not sure if this should be reported here at cython. I will likely try to bisect this to the cython change later today.
The text was updated successfully, but these errors were encountered: