Skip to content

BUG: Unable to build Pandas on z/OS when using xlc #35826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
pitmanst opened this issue Aug 20, 2020 · 3 comments · Fixed by #35829
Closed
3 tasks done

BUG: Unable to build Pandas on z/OS when using xlc #35826

pitmanst opened this issue Aug 20, 2020 · 3 comments · Fixed by #35829
Labels
Build Library building on various platforms
Milestone

Comments

@pitmanst
Copy link
Contributor

  • I have checked that this issue has not already been reported

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


Problem description

When building Pandas using xlc on z/OS, it errors out with the following message:

"pandas/_libs/window/aggregations.cpp", line 25295.13: CCN5888 (S) The current option settings do not allow the use of "long long". The suffix of the integer literal "1LL" is not valid.

This seems to be due to xlc++ needing specific options to be set when building the c++ code (need to swap the language standard to one that supports long long). However, after adding this via CFLAGS, it'll then error out with the following:

 "pandas/_libs/window/aggregations.cpp", line 5461.18: CCN5130 (S) "std::__class" is not declared.
  "pandas/_libs/window/aggregations.cpp", line 5548.18: CCN5130 (S) "std::__class" is not declared.
  "pandas/_libs/window/aggregations.cpp", line 6783.16: CCN5130 (S) "std::__class" is not declared.
  "pandas/_libs/window/aggregations.cpp", line 19752.16: CCN5130 (S) "std::__class" is not declared.

While the error messages are different and is on a different platform/OS, this issue might be related to #35123. I haven't tested on AIX so cannot confirm this however. FYI - @aixtools - since this will need a fix for xlc on z/OS, it seems likely that it will apply to AIX as well. What it seems to be is that there is support for those functions within xlc, but they're not placed within the std:: namespace (macros from older standards).

Since there's two build errors here for z/OS, I'll be opening this issue rather than dup'ing the other issue.

@pitmanst pitmanst added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 20, 2020
@jreback jreback added Build Library building on various platforms and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 20, 2020
@jreback
Copy link
Contributor

jreback commented Aug 20, 2020

thanks @pitmanst note that we don't have any support for these platforms (meaning we don't test); that said will take patches.

@bashtage
Copy link
Contributor

bashtage commented Aug 20, 2020 via email

@pitmanst
Copy link
Contributor Author

I'm using the latest version of xlc & xlc++ to build Pandas currently.

For reference, there's two different c & c++ compilers currently supported on z/OS. There's xlc/xlc++, and xlclang/xlclang++. xlc Only has moderate support of c++11, which fails to build Pandas currently - I have a patch which will be ready shortly which works around this. I also tested xlclang/xlclang++, and it works fine for building Pandas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants