Skip to content

CI: revert disable of windows window/moments tests #37535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Oct 31, 2020 · 8 comments · Fixed by #44239
Closed

CI: revert disable of windows window/moments tests #37535

jreback opened this issue Oct 31, 2020 · 8 comments · Fixed by #44239
Assignees
Labels
CI Continuous Integration Window rolling, ewma, expanding Windows Windows OS

Comments

@jreback
Copy link
Contributor

jreback commented Oct 31, 2020

Here we disable collection of the windowing tests only on windows: #37455

let's see if we an figure out where this is coming on.

cc @mroeschke @AlexKirko @jbrockmendel

@jreback jreback added Bug CI Continuous Integration Windows Windows OS Window rolling, ewma, expanding labels Oct 31, 2020
@jreback jreback added this to the 1.2 milestone Oct 31, 2020
@nagesh-chowdaiah
Copy link
Contributor

nagesh-chowdaiah commented Oct 31, 2020

@jreback

if [[ $(uname) != "Linux"  && $(uname) != "Darwin" ]]; then
    # GH#37455 windows py38 build appears to be running out of memory
    #  skip collection of window tests
    PYTEST_CMD="$PYTEST_CMD --ignore=pandas/tests/window/"
fi

I think we need to revert this change to enable the window test for windows

if yes can i can take this ticket

@nagesh-chowdaiah
Copy link
Contributor

take

@jreback
Copy link
Contributor Author

jreback commented Oct 31, 2020

to be clear we need to actually fix the failing tests when all are run on windows before this is reverted.

@nagesh-chowdaiah
Copy link
Contributor

I think we should have kept the PR open to understand the issue.. and debug more on that. I have heard that the issues are been generated by node.js. are we using node anywhere in the code

@jreback
Copy link
Contributor Author

jreback commented Oct 31, 2020

not sure what this has to do with node.js

this issue has been around for a while - you are welcome to debug
pls indicate if that is the case in thr PR by making it a draft

@mroeschke
Copy link
Member

@jbrockmendel why were the tests/window excluded specifically?

@jbrockmendel
Copy link
Member

i figured they had a large ratio of collection-overhead to actually-being-run. ill have no objection if you want to re-enable them and do something more targeted

@mroeschke
Copy link
Member

Gotcha. Just curious if it was something known about those tests in particular that was specifically causing the memory issues.

@jreback jreback modified the milestones: 1.2, Contributions Welcome Nov 25, 2020
@jorisvandenbossche jorisvandenbossche modified the milestones: Contributions Welcome, 1.3 Nov 26, 2020
@mroeschke mroeschke changed the title CI: revert disable of windows window tests CI: revert disable of windows window/moments tests May 20, 2021
@mroeschke mroeschke removed this from the 1.3 milestone May 20, 2021
@mroeschke mroeschke removed the Bug label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Window rolling, ewma, expanding Windows Windows OS
Projects
None yet
5 participants