-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: revert disable of windows window/moments tests #37535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think we need to revert this change to enable the window test for windows if yes can i can take this ticket |
take |
to be clear we need to actually fix the failing tests when all are run on windows before this is reverted. |
I think we should have kept the PR open to understand the issue.. and debug more on that. I have heard that the issues are been generated by node.js. are we using node anywhere in the code |
not sure what this has to do with node.js this issue has been around for a while - you are welcome to debug |
@jbrockmendel why were the |
i figured they had a large ratio of collection-overhead to actually-being-run. ill have no objection if you want to re-enable them and do something more targeted |
Gotcha. Just curious if it was something known about those tests in particular that was specifically causing the memory issues. |
Here we disable collection of the windowing tests only on windows: #37455
let's see if we an figure out where this is coming on.
cc @mroeschke @AlexKirko @jbrockmendel
The text was updated successfully, but these errors were encountered: