Skip to content

CI: flake8 check does not work properly #37940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
charlesdong1991 opened this issue Nov 18, 2020 · 0 comments
Closed

CI: flake8 check does not work properly #37940

charlesdong1991 opened this issue Nov 18, 2020 · 0 comments
Labels
CI Continuous Integration

Comments

@charlesdong1991
Copy link
Member

charlesdong1991 commented Nov 18, 2020 •
edited
Loading

xref #37938

Have seen it in #37923 and in #37703 , so ci checks ran successfully in those feature PRs, but actually they should have detected this unused import.

Basically flake8 check in CI should detect cases such as unused imports, however, right now, observed from those two PRs, it didn't detect them in feature PRs and then resulted in CI failure on master
@charlesdong1991 charlesdong1991 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 18, 2020
@charlesdong1991 charlesdong1991 changed the title CI: CI flake8 does not work properly CI: flake8 check does not work properly Nov 18, 2020
@charlesdong1991 charlesdong1991 added CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 18, 2020
@charlesdong1991 charlesdong1991 mentioned this issue Nov 18, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@charlesdong1991