Skip to content

DOC: example for doing a reversed rolling window #38627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 21, 2020 · 7 comments · Fixed by #41842
Closed

DOC: example for doing a reversed rolling window #38627

jreback opened this issue Dec 21, 2020 · 7 comments · Fixed by #41842
Assignees
@mdhsieh
Labels
Docs good first issue Window rolling, ewma, expanding

Comments

@jreback
Copy link
Contributor

jreback commented Dec 21, 2020

#34226 (comment) is the example, should just add to window.rst

also would be good to show using https://pandas.pydata.org/pandas-docs/dev/reference/api/pandas.api.indexers.FixedForwardWindowIndexer.html?highlight=forward#pandas.api.indexers.FixedForwardWindowIndexer
@jreback jreback added Docs good first issue Window rolling, ewma, expanding labels Dec 21, 2020
@jreback jreback added this to the Contributions Welcome milestone Dec 21, 2020
@willb0246 willb0246 mentioned this issue Dec 23, 2020
Closed
@MaruthiKo
Copy link
Contributor

Dear Developer,
I am new to open source contributions and I would like to contribute. Can someone pls help me up with how and where do I start?

@mzeitlin11
Copy link
Member

Hi @MaruthiKo, welcome to pandas! I'd recommend reading https://pandas.pydata.org/docs/development/contributing.html for guidance on contribution to pandas. If you'd like to work on this issue, the Contributing to the documentation section should be particularly useful.

@vangorade
Copy link
Contributor

looks like issue is still not resolved let me fix it real quick.

@vangorade
Copy link
Contributor

take

@vangorade vangorade mentioned this issue Jan 10, 2021
Closed
4 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.3 Jan 13, 2021
@hvp004
Copy link

hvp004 commented Mar 5, 2021

Is this available to take? I see no updates in almost 2 months.

@mdhsieh
Copy link
Contributor

mdhsieh commented Jun 6, 2021

I can make suggested changes from the closed pull request.

@mdhsieh
Copy link
Contributor

mdhsieh commented Jun 6, 2021

take

mdhsieh added a commit to mdhsieh/pandas that referenced this issue Jun 6, 2021
@mdhsieh
DOC: Add examples to do reversed rolling window (pandas-dev#38627).
462636f 
File is copied from @vangorade last changes in pull request (pandas-dev#39091):
pandas-dev#39091

Fixed typo to pass pre-commit codespell hook.
mdhsieh added a commit to mdhsieh/pandas that referenced this issue Jun 6, 2021
@mdhsieh
DOC: Add suggested changes to reverse rolling window code examples (p…
c15c0bb 
…andas-dev#38627).

Move code example as suggested in pull request (pandas-dev#39091):
pandas-dev#39091

Compiled document to check it looked fine by running:
python make.py --single user_guide/window.rst
@mdhsieh mdhsieh mentioned this issue Jun 6, 2021
Merged
4 tasks
@simonjayhawkins simonjayhawkins removed this from the 1.3 milestone Jun 8, 2021
mroeschke pushed a commit that referenced this issue Jun 11, 2021
@mdhsieh
DOC: reverse rolling window (#38627) (#41842)
d265e21 
* DOC: Add examples to do reversed rolling window (#38627).

File is copied from @vangorade last changes in pull request (#39091):
#39091

Fixed typo to pass pre-commit codespell hook.

* DOC: Add some suggested changes.

From pull request (#39091):
#39091

- remove noqa
- change line back to single quotes
- rename df1 to reversed_df

* DOC: Add reference to FixedForwardWindowIndexer.

* DOC: Add more suggested changes.

From pull request (#39091):
#39091

- remove repeated df initialization in code example
- rename df2 to reversed_df

* DOC: Add suggested changes to reverse rolling window code examples (#38627).

Move code example as suggested in pull request (#39091):
#39091

Compiled document to check it looked fine by running:
python make.py --single user_guide/window.rst

* DOC: Revert more double quotes to single quotes.

Unecessary changes.

* DOC: Change binary window description to match master branch.

Description was not modified after fetching and merging, so pasted from master branch:
https://github.com/pandas-dev/pandas/blob/master/doc/source/user_guide/window.rst

* DOC: Change exponentially weighted mean formula to one in master branch.

Since fetching and merging didn't modify this line.

* DOC: Replace window.rst with file from pandas-dev master branch.

To only add reverse rolling window section and avoid any unwanted changes.

* DOC: Add section with reverse rolling window example.

* DOC: Add section markup.

Forgot to add.

* DOC: Delete the same code example.

FixedForwaredWindowIndexer example is same as the one above the added section.

* DOC: Remove section and first sentence.

Modify sentence slightly to show this example should output same result.

* DOC: Remove unecessary words.

Coding is already in Python.
JulianWgs pushed a commit to JulianWgs/pandas that referenced this issue Jul 3, 2021
@mdhsieh @JulianWgs
DOC: reverse rolling window (pandas-dev#38627) (pandas-dev#41842)
08bcfa8 
* DOC: Add examples to do reversed rolling window (pandas-dev#38627).

File is copied from @vangorade last changes in pull request (pandas-dev#39091):
pandas-dev#39091

Fixed typo to pass pre-commit codespell hook.

* DOC: Add some suggested changes.

From pull request (pandas-dev#39091):
pandas-dev#39091

- remove noqa
- change line back to single quotes
- rename df1 to reversed_df

* DOC: Add reference to FixedForwardWindowIndexer.

* DOC: Add more suggested changes.

From pull request (pandas-dev#39091):
pandas-dev#39091

- remove repeated df initialization in code example
- rename df2 to reversed_df

* DOC: Add suggested changes to reverse rolling window code examples (pandas-dev#38627).

Move code example as suggested in pull request (pandas-dev#39091):
pandas-dev#39091

Compiled document to check it looked fine by running:
python make.py --single user_guide/window.rst

* DOC: Revert more double quotes to single quotes.

Unecessary changes.

* DOC: Change binary window description to match master branch.

Description was not modified after fetching and merging, so pasted from master branch:
https://github.com/pandas-dev/pandas/blob/master/doc/source/user_guide/window.rst

* DOC: Change exponentially weighted mean formula to one in master branch.

Since fetching and merging didn't modify this line.

* DOC: Replace window.rst with file from pandas-dev master branch.

To only add reverse rolling window section and avoid any unwanted changes.

* DOC: Add section with reverse rolling window example.

* DOC: Add section markup.

Forgot to add.

* DOC: Delete the same code example.

FixedForwaredWindowIndexer example is same as the one above the added section.

* DOC: Remove section and first sentence.

Modify sentence slightly to show this example should output same result.

* DOC: Remove unecessary words.

Coding is already in Python.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdhsieh mdhsieh

Labels
Docs good first issue Window rolling, ewma, expanding
Projects
None yet
Milestone
No milestone
7 participants
@jreback @hvp004 @simonjayhawkins @mzeitlin11 @mdhsieh @MaruthiKo @vangorade