Skip to content

CLN: Simplify inspect_excel_format #38822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Dec 30, 2020 · 1 comment
Closed

CLN: Simplify inspect_excel_format #38822

rhshadrach opened this issue Dec 30, 2020 · 1 comment
Labels
Clean Duplicate Report Duplicate issue or pull request IO Excel read_excel, to_excel

Comments

@rhshadrach
Copy link
Member

The function io.excel._base.inspect_excel_format does not need to take two parameters path and content since either is passed to get_handle. It should instead take a single parameter, path_or_buf.
@rhshadrach rhshadrach added IO Excel read_excel, to_excel Clean labels Dec 30, 2020
@rhshadrach rhshadrach added this to the Contributions Welcome milestone Dec 30, 2020
@simonjayhawkins
Copy link
Member

duplicate of #38823

@simonjayhawkins simonjayhawkins added the Duplicate Report Duplicate issue or pull request label Dec 30, 2020
@simonjayhawkins simonjayhawkins modified the milestones: Contributions Welcome, No action Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Duplicate Report Duplicate issue or pull request IO Excel read_excel, to_excel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonjayhawkins @rhshadrach