Skip to content

CLN: Simplify inspect_excel_format #38823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rhshadrach opened this issue Dec 30, 2020 · 1 comment · Fixed by #39008
Closed

CLN: Simplify inspect_excel_format #38823

rhshadrach opened this issue Dec 30, 2020 · 1 comment · Fixed by #39008
Assignees
@lithomas1
Labels
Clean IO Excel read_excel, to_excel
Milestone
1.3

Comments

@rhshadrach
Copy link
Member

ref: #38819

The function io.excel._base.inspect_excel_format does not need to take two parameters path and content since either is passed to get_handle. It should instead take a single parameter, path_or_buf.
@rhshadrach rhshadrach added IO Excel read_excel, to_excel Clean labels Dec 30, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Dec 30, 2020
Closed
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Dec 30, 2020
@lithomas1
Copy link
Member

take

@lithomas1 lithomas1 mentioned this issue Jan 6, 2021
Merged
4 tasks
@jreback jreback modified the milestones: Contributions Welcome, 1.3 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lithomas1 lithomas1

Labels
Clean IO Excel read_excel, to_excel
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

CLN: inspect_excel_format lithomas1/pandas
4 participants
@jreback @simonjayhawkins @rhshadrach @lithomas1