Skip to content

REF: in pandas.io.common integerate BytesIOWrapper into IOHandle #39383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arw2019 opened this issue Jan 24, 2021 · 1 comment · Fixed by #42669
Closed

REF: in pandas.io.common integerate BytesIOWrapper into IOHandle #39383

arw2019 opened this issue Jan 24, 2021 · 1 comment · Fixed by #42669
Assignees
@lithomas1
Labels
Internals Related to non-user accessible pandas implementation IO Data IO issues that don't fit into a more specific label Refactor Internal refactoring of code
Milestone
1.4

Comments

@arw2019
Copy link
Member

arw2019 commented Jan 24, 2021

references:

pyarrow requires BytesIO not StringIO so in #38370 we add a class that returns a binary handle to reader input. This class (BytesIOWrapper) should be integrated into IOHandle to better align with the patterns we use elsewhere for file handles (#37639 is the PR that standardized things)

I originally intended to do this in #38370 but I got a little stuck and since that PR is sizeable already I think it's better to spin it off into a separate follow-on task
@arw2019 arw2019 added Bug Needs Triage Issue that has not been reviewed by a pandas team member Refactor Internal refactoring of code IO CSV read_csv, to_csv IO Data IO issues that don't fit into a more specific label Internals Related to non-user accessible pandas implementation and removed Bug IO Data IO issues that don't fit into a more specific label labels Jan 24, 2021
@lithomas1 lithomas1 removed the Needs Triage Issue that has not been reviewed by a pandas team member label Feb 1, 2021
@twoertwein twoertwein mentioned this issue Feb 23, 2021
Closed
3 tasks
@lithomas1 lithomas1 self-assigned this May 4, 2021
@lithomas1 lithomas1 added IO Data IO issues that don't fit into a more specific label and removed IO CSV read_csv, to_csv labels May 4, 2021
@lithomas1
Copy link
Member

Going to be taking this one now. The main use case for this would be pyarrow reading text data, so would be CSV and maybe JSON if we want that in the future.

@lithomas1 lithomas1 mentioned this issue May 4, 2021
Closed
@lithomas1 lithomas1 mentioned this issue Jul 22, 2021
Merged
4 tasks
@jreback jreback added this to the 1.4 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lithomas1 lithomas1

Labels
Internals Related to non-user accessible pandas implementation IO Data IO issues that don't fit into a more specific label Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

ENH: Add BytesIOWrapper lithomas1/pandas
3 participants
@jreback @lithomas1 @arw2019