ASV Bug ? After commit 009c4c62.

[smarie]

It seems that commit 009c4c6 (fix in the to_json function) introduced some compilation problem on windows, that ASV does not like. Note that manual compilation seems to still work fine, so this is maybe related to the ASV config ?

> asv run d5cf2b86

"C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\link.exe" /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\_dev\pyt
hon_ws\_Libs_OpenSource\pandas\asv_bench\env\45e7123d25d88e958f183355b52ee854\libs /LIBPATH:C:\_dev\python_ws\_Libs_OpenSource\pandas\asv_bench\env\45e7123d25d88e958f183355b52ee854 /LIBPATH:C:\_dev\python_ws\_Li
bs_OpenSource\pandas\asv_bench\env\45e7123d25d88e958f183355b52ee854\PCbuild\amd64 "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\lib\x64" "/LIBPATH:C:\Program 
Files (x86)\Windows Kits\10\lib\10.0.17763.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.17763.0\um\x64" "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\
MSVC\14.16.27023\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.17763.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.17763.0\um\x64" "/LIBPATH:C:\Program Files (x86)\Mi
crosoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.17763.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.1776
3.0\um\x64" "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.17763.0\ucrt\x64" "/LIBPATH:C:\Pr
ogram Files (x86)\Windows Kits\10\lib\10.0.17763.0\um\x64" /EXPORT:PyInit_json build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson/lib/ultrajsondec.obj build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson
/lib/ultrajsonenc.obj build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson/python/JSONtoObj.obj build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson/python/date_conversions.obj build\temp.win-amd64-3.8\Rel
ease\pandas/_libs/src/ujson/python/objToJSON.obj build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson/python/ujson.obj build\temp.win-amd64-3.8\Release\pandas/_libs/tslibs/src/datetime/np_datetime.obj build\t
emp.win-amd64-3.8\Release\pandas/_libs/tslibs/src/datetime/np_datetime_strings.obj /OUT:build\lib.win-amd64-3.8\pandas\_libs\json.cp38-win_amd64.pyd /IMPLIB:build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujso
n/lib\json.cp38-win_amd64.lib
      Cr�ation de la biblioth�que build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson/lib\json.cp38-win_amd64.lib et de l'objet build\temp.win-amd64-3.8\Release\pandas/_libs/src/ujson/lib\json.cp38-win_amd64
.exp
   G�n�ration de code en cours
   Fin de la g�n�ration du code
   Fin de la g�n�ration du code
   STDERR -------->
   no previously-included directories found matching 'doc\build'
   warning: no previously-included files matching '*.so' found anywhere in distribution
   warning: no previously-included files matching '*~' found anywhere in distribution
   warning: no previously-included files matching '.DS_Store' found anywhere in distribution
   warning: no previously-included files matching '#*' found anywhere in distribution
   warning: no previously-included files matching '*.py[ocd]' found anywhere in distribution
   error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x64\\cl.exe' failed with exit code 1

[smarie]

Note that I discovered this while completing #46759

[lithomas1]

Can you attach the full log with the compiler error?

[smarie]

Sure. asv run "d5cf2b86^!" -v > asvrun_d5cf2b86.log :

asvrun_d5cf2b86.zip

It seems (but maybe I'm mistaken?) to be related to some permission issue while reading the dependencies for the json lib. What I do not understand is that this issue suddenly appears at this commit, but the previous one works fine.

EDIT: do you know where asv actually stores the built files ? I cant find it any of them in the asv-build-cache dir..

[lithomas1]

The lines responsible for building pandas can be found here.

pandas/asv_bench/asv.conf.json

Lines 128 to 130 in a160caf

	"build_command":
	["python setup.py build -j4",
	"PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"],

.
You could try running a python setup.py clean beforehand.

However, this looks like #30873, where there is a race condition in writing the np_datetime.c. I think you can try to change build_ext to -j1 in the asv conf.json.

(P.S. asv stores the conda environment under the asv_bench/env folder).

[smarie]

Thanks for the feedback ! Indeed using -j1 solves the issue. It was the same problem as in #30873