Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: newer version of s3fs is pulled causing builds to fail #48271

Closed
phofl opened this issue Aug 26, 2022 · 2 comments · Fixed by #48299
Closed

CI: newer version of s3fs is pulled causing builds to fail #48271

phofl opened this issue Aug 26, 2022 · 2 comments · Fixed by #48299
Labels
CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues
Milestone
1.5

Comments

@phofl
Copy link
Member

phofl commented Aug 26, 2022 •
edited
Loading

Looks like we are pulling 0.6.0 (which is way smaller than our minimum version btw) instead of 0.4.2. The 0.6.0 requires aiobotocore, but is not compatible with the new version.

Working build:
https://github.com/pandas-dev/pandas/runs/8026125010?check_suite_focus=true

Failed build:
https://github.com/pandas-dev/pandas/runs/8035127801?check_suite_focus=true

Lets try to force at least the minimum s3fs version.
@phofl phofl changed the title ICI CI: newer version of s3fs is pulled causing builds to fail Aug 26, 2022
@phofl phofl mentioned this issue Aug 26, 2022
Merged
1 task
@simonjayhawkins simonjayhawkins mentioned this issue Aug 26, 2022
Merged
@phofl
Copy link
Member Author

phofl commented Aug 26, 2022

Our minimum version of s3fs is not compatible with aiobotocore >= 2.0, so have to pin to lower than 2.0 till we bump s3fs

@simonjayhawkins simonjayhawkins added this to the 1.5 milestone Aug 26, 2022
@simonjayhawkins simonjayhawkins added CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues labels Aug 26, 2022
@simonjayhawkins
Copy link
Member

milestoning as 1.5 for now. will backport to 1.4.x if needed.

@lithomas1 lithomas1 mentioned this issue Aug 28, 2022
Closed
5 tasks
@phofl phofl mentioned this issue Aug 29, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

Bump s3fs to 2021.08.00 phofl/pandas
CI: Force newer S3FS lithomas1/pandas
2 participants
@simonjayhawkins @phofl