Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add light/dark theme switcher #48598

Closed
datapythonista opened this issue Sep 17, 2022 · 15 comments · Fixed by #48703
Closed

DOC: Add light/dark theme switcher #48598

datapythonista opened this issue Sep 17, 2022 · 15 comments · Fixed by #48703

Comments

@datapythonista
Copy link
Member

With the upgrade to the latest version of pydata-sphinx-theme (see #48285) our docs now are available in dark mode. By default, the Sphinx theme will use the version (light/dark) set up by the user. But would be nice to add a switcher to the navigation bar of the docs, so users can change the theme manually.

See for example in the top right corner of https://www.blosc.org/c-blosc2/c-blosc2.html the icon to change the sphinx theme. I think we should add the same to the pandas docs too.

@deepaksirohiwal
Copy link
Contributor

Hi, I am new to open source and would love to work on this issue. Can you assign this to me?

@datapythonista
Copy link
Member Author

Assigned. In the pandas repo, if you write /take in a comment of an issue or PR, it should get assigned to you. Thanks for working on this. If you need help setting up the environment... You can have a look at the developers documentation: https://pandas.pydata.org/docs/dev/development/index.html

@deepaksirohiwal
Copy link
Contributor

@datapythonista thank you for assigning me this issue.

@deepaksirohiwal
Copy link
Contributor

Hi @datapythonista, I wanted to know for which page exactly the dark theme is available because I am able to see the dark theme only on https://pandas.pydata.org/docs/dev/ and where exactly you want me to implement the switch (page and location)?

@datapythonista
Copy link
Member Author

We are using sphinx and the pydata sphinx theme to generate our docs. We don't need to implement it, we just need to set up the theme to show the light/dark switcher. You can check the theme, https://github.com/pydata/pydata-sphinx-theme and the contributing to the docs section in our documentation to understand better.

@WooilKim
Copy link

@datapythonista
Hi, I want to use /take command for other issue, but it seems to be not working.
Does /take command need time to be assigned?
Actually, I want to work on #48561 .
Thanks.

@datapythonista
Copy link
Member Author

@datapythonista Hi, I want to use /take command for other issue, but it seems to be not working. Does /take command need time to be assigned? Actually, I want to work on #48561 . Thanks.

Ah, sorry, I think it may be take without the slash in pandas. Implemented in other projects too as /take, but when I implemented it in pandas having a heading slash was not usual yet

@WooilKim
Copy link

@datapythonista
Oh I think it works.
I think it will be better to provide guide about the commands such as "take" for newbies like me.

@datapythonista
Copy link
Member Author

It's documented in the developers guide in our docs, not sure exactly where, but you should be able to find it.

@EricKart
Copy link

Hi, can I too work on this issue?

@datapythonista
Copy link
Member Author

Hi, can I too work on this issue?

Sure, go ahead. Thank you!

@deepaksirohiwal
Copy link
Contributor

Hi @datapythonista , is there any other way to generate the web page as it is showing me requests.exceptions.HTTPError: 403 Client Error: rate limit exceeded for url: https://api.github.com/users/ this error. Do I need to regenerate the web page every time I make any changes?

@datapythonista
Copy link
Member Author

You can use --ignore-io-errors to avoid that error.

@lithomas1 lithomas1 modified the milestones: 1.5, Contributions Welcome Sep 19, 2022
@deepaksirohiwal
Copy link
Contributor

Hi @datapythonista, I have added a switcher to the doc file and I wanted to know how to write it in the documentation. Should I send a pull request first?
image
image

@datapythonista
Copy link
Member Author

Yes, if you have the changes locally, and want to get your changes into our official docs, the only way is opening a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants