-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add light/dark theme switcher #48598
Comments
Hi, I am new to open source and would love to work on this issue. Can you assign this to me? |
Assigned. In the pandas repo, if you write |
@datapythonista thank you for assigning me this issue. |
Hi @datapythonista, I wanted to know for which page exactly the dark theme is available because I am able to see the dark theme only on |
We are using sphinx and the pydata sphinx theme to generate our docs. We don't need to implement it, we just need to set up the theme to show the light/dark switcher. You can check the theme, https://github.com/pydata/pydata-sphinx-theme and the contributing to the docs section in our documentation to understand better. |
@datapythonista |
Ah, sorry, I think it may be |
@datapythonista |
It's documented in the developers guide in our docs, not sure exactly where, but you should be able to find it. |
Hi, can I too work on this issue? |
Sure, go ahead. Thank you! |
Hi @datapythonista , is there any other way to generate the web page as it is showing me |
You can use |
Hi @datapythonista, I have added a switcher to the doc file and I wanted to know how to write it in the documentation. Should I send a pull request first? |
Yes, if you have the changes locally, and want to get your changes into our official docs, the only way is opening a pull request |
With the upgrade to the latest version of
pydata-sphinx-theme
(see #48285) our docs now are available in dark mode. By default, the Sphinx theme will use the version (light/dark) set up by the user. But would be nice to add a switcher to the navigation bar of the docs, so users can change the theme manually.See for example in the top right corner of https://www.blosc.org/c-blosc2/c-blosc2.html the icon to change the sphinx theme. I think we should add the same to the pandas docs too.
The text was updated successfully, but these errors were encountered: