-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Open
Labels
Error ReportingIncorrect or improved errors from pandasIncorrect or improved errors from pandasRefactorInternal refactoring of codeInternal refactoring of code
Description
Many methods raise AbstractMethodError
instead of being an abstractmethod
. Based on #20363 and #19268 it seems that there might be a performance issue with inheriting from abc.ABC
:
This class does not inherit from 'abc.ABCMeta' for performance reasons.
I didn't find a reference of why inheriting from abc.ABC
is slow. Is that a python 2 thing? Would it make sense to use abc.ABC+abstractmethod
instead of raising AbstractMethodError
?
Metadata
Metadata
Assignees
Labels
Error ReportingIncorrect or improved errors from pandasIncorrect or improved errors from pandasRefactorInternal refactoring of codeInternal refactoring of code