STYLE enable pylint's redefined-outer-name #49656

MarcoGorelli · 2022-11-11T21:21:52Z

This warning could potentially prevent bugs, so I'm pretty keen on putting in the effort to enable it.

Many people can work on this one together. To work on it, please:

choose 2-3 files
make sure you have pylint version 2.15.5 installed (pip install pylint==2.15.5) - check this is the same as the number in the .pre-commit-config.yaml file
for each file, run pylint --disable=all --enable=redefined-outer-name <file>
fix up the file until it passes
stage, commit, push, open pull request

For example, suppose you choose the file pandas/io/json/_table_schema.py. Running pylint on it, you get:

$ pylint --disable=all --enable=redefined-outer-name pandas/io/json/_table_schema.py
************* Module pandas.io.json._table_schema
pandas/io/json/_table_schema.py:314:23: W0621: Redefining name 'json' from outer scope (line 15) (redefined-outer-name)

-----------------------------------
Your code has been rated at 9.92/10

If we look at that file, we see that there's a function

def parse_table_schema(json, precise_float):

which takes json as an argument, but the file also has

from pandas._libs import json

at the top.

The simplest fix is probably to just modify the import to be

from pandas._libs.json import loads

and then to remove

pandas/pandas/io/json/_table_schema.py

Line 44 in f9ff379

loads = json.loads

as loads is the only function used from pandas._libs.json.

Other notes:

multiple people can work on this issue at the same time, please don't comment 'take'
please choose no more than 3 files to work on in the same PR. Comment which files you'd like to take so we don't duplicate work

It's probably worth running pylint on a directory first to see what files need working on, e.g.

pylint --disable=all --enable=redefined-outer-name pandas/io/

Files that still need fixing:

pandas/_version.py
pandas/conftest.py
pandas/core/generic.py
pandas/core/internals/concat.py
pandas/core/reshape/merge.py
pandas/core/tools/datetimes.py
pandas/io/formats/format.py
pandas/io/formats/style.py
pandas/io/json/_json.py
pandas/io/xml.py
pandas/util/_decorators.py
pandas/util/_doctools.py

Let's ignore test files for now

The text was updated successfully, but these errors were encountered:

grtcoder · 2022-11-12T05:59:46Z

Hey, I would like to work on this

MarcoGorelli · 2022-11-12T06:12:36Z

go ahead - as mentioned in the issue:

please choose no more than 3 files to work on in the same PR. Comment which files you'd like to take so we don't duplicate work

ramvikrams · 2022-11-12T06:45:20Z

I'll take pandas\core\generic.py

grtcoder · 2022-11-12T08:02:38Z

I'll take

pandas/core/arrays/datetimelike.py
pandas/core/base.py
pandas/core/computation/pytables.py

Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py

Dhrubajyoti-Giri · 2022-11-12T15:29:27Z

I'll take pandas/core/internals/concat.py, pandas/core/reshape/merge.py, pandas/io/json/_json.py.

bhaveshrp · 2022-11-12T16:36:49Z

I'll take

pandas\core\frame.py
pandas\core\dtypes\inference.py

alphacrack · 2022-11-12T16:49:07Z

I'll take:

pandas/core/dtypes/cast.py
pandas/core/dtypes/dtypes.py
pandas/core/indexes/base.py

aditya-anulekh · 2022-11-12T22:11:07Z

Added a pull request fixing the following files

pandas/core/indexes/datetimes.py
pandas/io/formats/xml.py
pandas/io/json/_table_schema.py

Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py

Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py Iteration :- 2

* STYLE: fix pylint redefined-outer-name warnings (#49656) Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py * STYLE: fix pylint redefined-outer-name warnings (#49656) Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py Iteration :- 2

nandinimalik16 · 2022-11-13T11:53:25Z

I will take

pandas/_version.py
pandas/conftest.py
pandas/io/formats/format.py

isaac-chung · 2022-11-13T22:15:09Z

I'll take:

pandas/plotting/_matplotlib/converter.py
pandas/plotting/_matplotlib/core.py
pandas/plotting/_matplotlib/tools.py

seanjedi · 2022-11-15T03:24:28Z

Hi, I'd like to work on:

pandas/io/formats/style.py
pandas/io/json/_json.py
pandas/io/xml.py

zemnly · 2022-11-15T08:06:08Z

Are there any files which haven't been taken so I can work on them?

MarcoGorelli · 2022-11-15T08:18:20Z

Yeah there's still some, I've updated the issue with an up-to-date list

Note that https://github.com/pandas-dev/pandas/pull/49668/files is already tackling some, but the rest should be up for grabs

Thanks all for your help with this one 🙏

zemnly · 2022-11-15T08:27:25Z

Thanks, I'd like to take :

pandas/core/algorithms.py
pandas/core/generic.py
pandas/core/tools/datetimes.py

calhockemeyer · 2022-11-15T08:36:56Z

I will take: pandas/core/resample.py. I think that's the only file that hasn't been taken

bang128 · 2022-11-15T09:27:16Z

Can I also contribute to pandas/core/algorithms.py?

ramvikrams · 2022-11-15T09:30:51Z

Can I also contribute to pandas/core/algorithms.py?

Yes you can i'll leave that file

bang128 · 2022-11-15T09:32:04Z

Can I also contribute to pandas/core/algorithms.py?

Yes you can i'll leave that file

Thank you so much!

* Fix concat.py * #49656: update concat.py, fix merge.py * #49656: update concat.py and merge.py

MarcoGorelli · 2022-11-24T18:58:28Z

We're almost done, there's just:

pandas/io/formats/format.py
pandas/core/generic.py

left

If anyone wants to take them, and then (in the same PR) remove these lines from .pre-commit-config.yaml

pandas/.pre-commit-config.yaml

Lines 81 to 83 in 0429b64

    
                       |^pandas/core/tools/datetimes\.py 
        
                       |^pandas/io/formats/format\.py 
        
                       |^pandas/core/generic\.py

, then we can close the issue

Thextan · 2022-11-24T21:32:31Z

I will make changes to pandas/core/generic.py and pandas/.pre-commit-config.yaml.
This is my first time contributing and I am not very familiar with git so, please help me out if I am doing anything wrong.

angularOcean · 2022-11-24T22:28:20Z

@Thextan I think we need to fix both format.py and generic.py before we can remove the lines from .pre-commit-config.yaml

Thextan · 2022-11-24T22:43:13Z

@angularOcean when I ran my check it looked like someone had already fixed io/formats/format.py. I could be mistaken about that. And my changes are not passing the checks, so I may not even be ready for this simple beginner task.

Also, I didn't think the changes to .pre-commit-config.yaml was related to the refactoring for redefine-outer-name.

MarcoGorelli · 2022-11-24T22:46:36Z

I'll take a look tomorrow, but if you search for the pandas contributing guide you'll find instructions for how to run the precommit checks

Thextan · 2022-11-26T19:41:44Z

Please feel free to pick up the changes to core/generic.py, io/formats/format.py (if it still needs work), and .pre-commit-config.yaml. I am reading through the contributing guide to make sure I am doing things correctly.

…andas-dev#49662) * STYLE: fix pylint redefined-outer-name warnings (pandas-dev#49656) Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py * STYLE: fix pylint redefined-outer-name warnings (pandas-dev#49656) Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py Iteration :- 2

…pandas-dev#49708) * t1 * update * update * Update generic.py * update * Update generic.py * Update generic.py * Update generic.py * Update generic.py * Update generic.py * Update generic.py * Update generic.py

…andas-dev#49743) pandas/core/algorithms.py

* Fix concat.py * pandas-dev#49656: update concat.py, fix merge.py * pandas-dev#49656: update concat.py and merge.py

MarcoGorelli · 2022-11-27T17:29:13Z

@Thextan not sure what you mean, sorry - your PR has been reviewed, do you plan to address the review? If not, no worries, that's fine, but please close the PR so others can work on it

MarieKMiko · 2022-11-27T18:38:25Z

If there are still changes to be made to pandas/io/formats/format.py or pandas/core/generic.py, I'm happy to take these on

MarcoGorelli · 2022-11-27T20:02:57Z

Yup, they're still open, if you wanted to submit a PR that'd be great, feel free to reach out (here or on the slack) if anything trips you up

antocommi · 2022-11-27T21:07:36Z

i'll take pandas/core/generic.py

bang128 · 2022-11-28T08:20:45Z

Have anyone taken pandas/io/formats/format.py yet? If not, can I take it?

…49937) * changed decimal module import, Decimal function call in EngFormatter class __call__ function * changed name of parameter for get_format_datetime64 to avoid redefined outer name conflict with is_dates_only function * change in argument name for call to get_format_datetime64 to match change in datetimes.py * removed import - justify function not used and creating redefined outer name conflict with justify functions defined for TextAdjustment and EastAsianTextAdjustment classes * replaced justify import with alias to avoid redefined-outer-name conflict * renamed imports from printing module * function renamed to is_dates_only_, returned argument for get_formate_datetime64 to is_dates_only * changes in datetimes.py to reflect function and argument names in format.py * argument and function names swapped * function name is is_dates_only, argument for get_format_datetime64 is is_dates_only_ * Update .pre-commit-config.yaml removed format and datetimes files

MarcoGorelli · 2022-11-29T19:08:10Z

only pandas/core/generic.py is left, if anyone wants to finish off this issue - doesn't look like there's any PR open

bang128 · 2022-11-29T19:14:35Z

I can take it if no one is working on it

MarcoGorelli · 2022-11-29T19:22:32Z

go ahead thanks

* Update format.py * Update format.py 9.99/10 * Update generic.py * Return format.py * Update generic.py * Update generic.py based on request change * Done pre-commit

MarcoGorelli · 2023-01-04T12:05:55Z

Looks like we forgot to remove this line

pandas/.pre-commit-config.yaml

Line 97 in a955989

|^pandas/core/generic\.py

anyone feel like opening a PR to remove it?

ramvikrams · 2023-01-04T17:28:02Z

pandas/.pre-commit-config.yaml

Done

Update .pre-commit-config.yaml

MarcoGorelli added Code Style Code style, linting, code_checks good first issue labels Nov 11, 2022

MarcoGorelli mentioned this issue Nov 11, 2022

STYLE fix pylint issues #48855

Closed

aditya-anulekh mentioned this issue Nov 12, 2022

STYLE: Fixed redefined-outer-name linting issue #49675

Merged

isaac-chung mentioned this issue Nov 13, 2022

STYLE: Fix redefined-outer-name linting issue #49687

Merged

4 tasks

MarcoGorelli pushed a commit that referenced this issue Nov 23, 2022

Fix STYLE #49656: concat.py and merge.py (#49853)

474b3db

* Fix concat.py * #49656: update concat.py, fix merge.py * #49656: update concat.py and merge.py

mliu08 pushed a commit to mliu08/pandas that referenced this issue Nov 27, 2022

STYLE: fix pylint redefined-outer-name warnings (pandas-dev#49656) (p…

9e6eab4

…andas-dev#49743) pandas/core/algorithms.py

mliu08 pushed a commit to mliu08/pandas that referenced this issue Nov 27, 2022

Fix STYLE pandas-dev#49656: concat.py and merge.py (pandas-dev#49853)

2733cc2

* Fix concat.py * pandas-dev#49656: update concat.py, fix merge.py * pandas-dev#49656: update concat.py and merge.py

This was referenced Nov 29, 2022

Update format.py #49956

Closed

STYLE #49656: format.py - 9.99/10 #49957

Closed

bang128 mentioned this issue Nov 29, 2022

STYLE: #49656 - generic.py #49960

Merged

5 tasks

bang128 added a commit to bang128/pandas that referenced this issue Nov 29, 2022

Merge branch 'main' into Fix-pandas-dev#49656-generic.py

9c6ff96

MarcoGorelli closed this as completed in #49960 Nov 29, 2022

MarcoGorelli pushed a commit that referenced this issue Nov 29, 2022

STYLE: #49656 - generic.py (#49960)

4d0a436

* Update format.py * Update format.py 9.99/10 * Update generic.py * Return format.py * Update generic.py * Update generic.py based on request change * Done pre-commit

ramvikrams mentioned this issue Jan 4, 2023

gh-49656:Removing unwanted line in .pre-commit-config.yaml #50561

Merged

5 tasks

MarcoGorelli pushed a commit that referenced this issue Jan 4, 2023

gh-49656:Removing unwanted line in .pre-commit-config.yaml (#50561)

8912f96

Update .pre-commit-config.yaml

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STYLE enable pylint's redefined-outer-name #49656

STYLE enable pylint's redefined-outer-name #49656

MarcoGorelli commented Nov 11, 2022 •

edited

Loading

grtcoder commented Nov 12, 2022

MarcoGorelli commented Nov 12, 2022

ramvikrams commented Nov 12, 2022 •

edited

Loading

grtcoder commented Nov 12, 2022 •

edited

Loading

Dhrubajyoti-Giri commented Nov 12, 2022

bhaveshrp commented Nov 12, 2022 •

edited

Loading

alphacrack commented Nov 12, 2022 •

edited

Loading

aditya-anulekh commented Nov 12, 2022

nandinimalik16 commented Nov 13, 2022 •

edited

Loading

isaac-chung commented Nov 13, 2022 •

edited

Loading

seanjedi commented Nov 15, 2022

zemnly commented Nov 15, 2022

MarcoGorelli commented Nov 15, 2022

zemnly commented Nov 15, 2022 •

edited

Loading

calhockemeyer commented Nov 15, 2022

bang128 commented Nov 15, 2022

ramvikrams commented Nov 15, 2022

bang128 commented Nov 15, 2022

MarcoGorelli commented Nov 24, 2022 •

edited

Loading

Thextan commented Nov 24, 2022

angularOcean commented Nov 24, 2022

Thextan commented Nov 24, 2022 •

edited

Loading

MarcoGorelli commented Nov 24, 2022

Thextan commented Nov 26, 2022

MarcoGorelli commented Nov 27, 2022

MarieKMiko commented Nov 27, 2022

MarcoGorelli commented Nov 27, 2022

antocommi commented Nov 27, 2022

bang128 commented Nov 28, 2022

MarcoGorelli commented Nov 29, 2022 •

edited

Loading

bang128 commented Nov 29, 2022

MarcoGorelli commented Nov 29, 2022

MarcoGorelli commented Jan 4, 2023

ramvikrams commented Jan 4, 2023

STYLE enable pylint's redefined-outer-name #49656

STYLE enable pylint's redefined-outer-name #49656

Comments

MarcoGorelli commented Nov 11, 2022 • edited Loading

grtcoder commented Nov 12, 2022

MarcoGorelli commented Nov 12, 2022

ramvikrams commented Nov 12, 2022 • edited Loading

grtcoder commented Nov 12, 2022 • edited Loading

Dhrubajyoti-Giri commented Nov 12, 2022

bhaveshrp commented Nov 12, 2022 • edited Loading

alphacrack commented Nov 12, 2022 • edited Loading

aditya-anulekh commented Nov 12, 2022

nandinimalik16 commented Nov 13, 2022 • edited Loading

isaac-chung commented Nov 13, 2022 • edited Loading

seanjedi commented Nov 15, 2022

zemnly commented Nov 15, 2022

MarcoGorelli commented Nov 15, 2022

zemnly commented Nov 15, 2022 • edited Loading

calhockemeyer commented Nov 15, 2022

bang128 commented Nov 15, 2022

ramvikrams commented Nov 15, 2022

bang128 commented Nov 15, 2022

MarcoGorelli commented Nov 24, 2022 • edited Loading

Thextan commented Nov 24, 2022

angularOcean commented Nov 24, 2022

Thextan commented Nov 24, 2022 • edited Loading

MarcoGorelli commented Nov 24, 2022

Thextan commented Nov 26, 2022

MarcoGorelli commented Nov 27, 2022

MarieKMiko commented Nov 27, 2022

MarcoGorelli commented Nov 27, 2022

antocommi commented Nov 27, 2022

bang128 commented Nov 28, 2022

MarcoGorelli commented Nov 29, 2022 • edited Loading

bang128 commented Nov 29, 2022

MarcoGorelli commented Nov 29, 2022

MarcoGorelli commented Jan 4, 2023

ramvikrams commented Jan 4, 2023

MarcoGorelli commented Nov 11, 2022 •

edited

Loading

ramvikrams commented Nov 12, 2022 •

edited

Loading

grtcoder commented Nov 12, 2022 •

edited

Loading

bhaveshrp commented Nov 12, 2022 •

edited

Loading

alphacrack commented Nov 12, 2022 •

edited

Loading

nandinimalik16 commented Nov 13, 2022 •

edited

Loading

isaac-chung commented Nov 13, 2022 •

edited

Loading

zemnly commented Nov 15, 2022 •

edited

Loading

MarcoGorelli commented Nov 24, 2022 •

edited

Loading

Thextan commented Nov 24, 2022 •

edited

Loading

MarcoGorelli commented Nov 29, 2022 •

edited

Loading