-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Simplify pandas theme footer #51536
Comments
take |
Hi @RamanathanVaradharajan, how is it going with this issue? |
You can probably go ahead @natmokval, thanks for the help! |
Hi @datapythonista. I started to work on this issue and got stuck. I created a pr #52149 to show the changes I've made so far. Could you please help and advise me on what could be my next step? |
Hi @datapythonista I'm working on it. |
Hi @datapythonista
And just pass the variable to the pandas_footer.html
But the template is still needed to render the context variable
Does anyone have any more ideas for getting rid of the template? |
Hi @datapythonista I've submitted a pull request that proposes a potential solution. |
Hello everyone, I just continue the work from the last PR which is now drafted. Can you take a look and provide suggestions? Thank you @datapythonista |
Hi @datapythonista , I would like to work on it. |
@datapythonista Hi, I would like to work on this issue. Please let me know. thanks |
The sphinx theme that we're using didn't let us specify what exactly to show in our footer in the configuration file. So, what we did was to create a custom template to overwrite everything. Seems like now they changed this in their end, and we should be able to implement in our end the footer we want without requiring the extra template. I didn't check in detail, so some research is needed to see if this is really possible.
Their changes haven't been released yet, so we can't really get this into production until they do. But we can get the PR ready by temporary changing the pydata-sphinx-theme dependency to the git version.
The text was updated successfully, but these errors were encountered: