-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CoW warning mode for cases that will change behaviour #56019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
This was referenced Nov 17, 2023
This was referenced Nov 27, 2023
Merged
This was referenced Dec 7, 2023
Since CoW is enabled on main I think we can close this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
We are adding a new "warning" mode for the Copy-on-Write option (#48998):
which will raise a warning in every case that you are doing a setitem operation that will change behaviour when Copy-on-Write is enabled (i.e. when you are setting on an object that shares a view with another object, and with current pandas would also update that other object)
This is a tracking issue for the subtasks to complete this:
mgr.setitem_inplace
): CoW: add warning mode for cases that will change behaviour #55428mgr.setitem
): CoW warning mode: add warning for single block setitem #55838mgr.column_setitem
): CoW warning mode: setting values into single column of DataFrame #56020mgr.iset
? (mostly used frommgr.column_setitem
which already raises the warning?)mgr._iset_single
? (this seems only covered bytest_internals.py::TestBlockManager::test_get_numeric_data/test_get_bool_data
, and so this is probably not possible to get to through public APIs)ser[0:2] += 1
) -> CoW: Remove false positive warnings for inplace operators #56242In addition, there are also a bunch of remaining
# TODO(CoW-warn)
to resolve.The text was updated successfully, but these errors were encountered: