Skip to content

Qt support reworked. #8788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datalyze-solutions opened this issue Nov 11, 2014 · 9 comments
Closed

Qt support reworked. #8788

datalyze-solutions opened this issue Nov 11, 2014 · 9 comments
Milestone

Comments

@datalyze-solutions
Copy link

I've rewritten the current qtpandas model and uploaded it to my pandas fork:
https://github.com/datalyze-solutions/pandas/tree/qt4/pandas/sandbox

Its still in sandbox. An example can be found in tests named TestApp.py. I just testet Qt4 and python2.7, Qt5 might be interesting.

Any reviews are welcome! 😃

@datalyze-solutions
Copy link
Author

Test are completeted. Custom delegates are working. Ready to go! 😃

@jorisvandenbossche
Copy link
Member

@datalyze-solutions It is easier to see/review the changes if you open a PR. But thanks for the work!

But something else, I was wondering if this part of pandas (qtpandas) wouldn't be appropriate to live as a separate project?

Not to discourage your efforts! I rather think this can be positive: not tied to the release process/schedule of pandas, encourage that some people take ownership of the project (I think there is at the moment not really a core developer who is actively maintaining this), publicize it separately, ..
And further, I think it also doesn't fully fit in the scope of core pandas.

@datalyze-solutions @rominf would you be interested in that?

@jreback @cpcloud @hayd @immerrr @takluyver

@immerrr
Copy link
Contributor

immerrr commented Nov 13, 2014

live as a separate project

I second that, all enumerated reasons make sense to me.

@rominf
Copy link

rominf commented Nov 13, 2014

Well, I actually agree with an idea to put this into separate project. I think that the vast majority of Pandas users don't need Qt bindings, moreover, the connection between those two projects is quite weak.

I propose to name it pandas-qt (Pandas is more important that the Qt in this project and people would search by pandas I think). Of course this should be uploaded to PyPi.

I haven't looked at your work, @datalyze-solutions, but it seems that rewriting everything from scratch was worth to do.

@jreback
Copy link
Contributor

jreback commented Nov 13, 2014

yep, +1 from me as well. A separate repo is worth it.

@datalyze-solutions
Copy link
Author

Well than, I start a seperate repo named pandas-qt.
Any recommendations which licence to use?

@jreback
Copy link
Contributor

jreback commented Nov 14, 2014

lots of projects use this: https://github.com/pydata/pandas/blob/master/LICENSE
though MIT I think is ok and Apache 2.0 as well

@datalyze-solutions
Copy link
Author

@jreback
Copy link
Contributor

jreback commented Mar 8, 2015

closing as qt support is now deprecated, see #9615

@jreback jreback closed this as completed Mar 8, 2015
@jreback jreback added this to the 0.16.0 milestone Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants