implemented fix for groupby date bug, #11324 #11460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdmc
changed the title
jreback
changed the title
| @@ -824,6 +824,32 @@ def test_apply_issues(self): | |||
| result = df.groupby('date').apply(lambda x: x['time'][x['value'].idxmax()]) | |||
| assert_series_equal(result, expected) | |||
|
|
|||
| def test_time_field_bug_no_conversion(self): | |||
| df = pd.DataFrame({ | |||
There was a problem hiding this comment.
add the issue number here as a coment
|
pls add a whatsnew comment (bug fix section), and squash. |
| @@ -824,6 +824,28 @@ def test_apply_issues(self): | |||
| result = df.groupby('date').apply(lambda x: x['time'][x['value'].idxmax()]) | |||
| assert_series_equal(result, expected) | |||
|
|
|||
| def test_time_field_bug(self): | |||
| # test a fix for GH issue 11324 | |||
There was a problem hiding this comment.
add a comment about what this bug fix is about
…das-dev#11324) Addressed PR comments Added comments and updated whatsnew
robdmc
force-pushed
the
fix_groupby_time_field_bug
branch
from
0f14ebc to
4791e15
Compare
|
Added comments to test, made an entry in v0.17.1.txt, and squashed commits. |
| @@ -117,3 +117,5 @@ Bug Fixes | |||
| - Bug in ``to_excel`` with openpyxl 2.2+ and merging (:issue:`11408`) | |||
|
|
|||
| - Bug in ``DataFrame.to_dict()`` produces a ``np.datetime64`` object instead of ``Timestamp`` when only datetime is present in data (:issue:`11327`) | |||
|
|
|||
| - Bug in ``pandas.core.groupby`` raises exception when ``func`` in ``df.groupby(...).apply(func)`` doesn't return existing time columns (:issue:`11324`) | |||
There was a problem hiding this comment.
make the text like your commit message, much simpler
|
merged via 5df693f thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #11324 in which grouping when datetime fields are involved raises an exceptoin