Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: pandas.stats.var, pandas.stats.plm, pandas.stats.ols, pandas.stats.fama_macbeth #11898

Merged
merged 4 commits into from
Dec 26, 2015

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Dec 24, 2015

closes #6077

this cleans ups the remainder of the pandas.stats modules

we are directing:

  • OLS -> http://statsmodels.sourceforge.net/stable/regression.html
  • PanelOLS/MovingOLS/PooledOLS to http://statsmodels.sourceforge.net/stable/mixed_linear.html
  • VAR to http://statsmodels.sourceforge.net/stable/vector_ar.html#var
  • fama_macbeth to http://statsmodels.sourceforge.net/stable/index.html (as not implemented in statsmodell, but good place to start)

@jreback jreback added Stats Deprecate Functionality to remove in pandas labels Dec 24, 2015
@jreback jreback added this to the 0.18.0 milestone Dec 24, 2015
@jreback
Copy link
Contributor Author

jreback commented Dec 24, 2015

cc @jseabold
cc @josef-pkt

looks reasonable?

@josef-pkt
Copy link

looks fine to me (without checking details)

Hopefully the deprecation warnings induce some users to help, at least with missing API and testing.
I can check panel models (missing conveniences for fixed effects handling) and move FamaMacBeth (given the example and test case in the issue) in late winter or spring.

I don't know if there is anything directly to do about expanding and rolling OLS or whether it's handled by just a call to the general pandas methods. (I haven't looked at that in years.)

@jreback
Copy link
Contributor Author

jreback commented Dec 26, 2015

thanks @josef-pkt

yeah meant to deprecate these a while ago.

@jorisvandenbossche
Copy link
Member

+1 !

jreback added a commit that referenced this pull request Dec 26, 2015
DEPR: pandas.stats.var, pandas.stats.plm, pandas.stats.ols, pandas.stats.fama_macbeth
@jreback jreback merged commit c45dc76 into pandas-dev:master Dec 26, 2015
jreback added a commit to jreback/pandas that referenced this pull request Feb 9, 2017
remove pd.ols, pd.fama_macbeth from top-level namespace

xref pandas-dev#11898
jreback added a commit to jreback/pandas that referenced this pull request Feb 9, 2017
remove pd.ols, pd.fama_macbeth from top-level namespace

xref pandas-dev#11898
jreback added a commit that referenced this pull request Feb 9, 2017
remove pd.ols, pd.fama_macbeth from top-level namespace

xref #11898
closes wesm/pandas2#26

previously deprecated in 0.18.0

Author: Jeff Reback <jeff@reback.net>

Closes #15353 from jreback/stats and squashes the following commits:

9563740 [Jeff Reback] DEPR: remove statsmodels as a dependency
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
remove pd.ols, pd.fama_macbeth from top-level namespace

xref pandas-dev#11898
closes wesm/pandas2#26

previously deprecated in 0.18.0

Author: Jeff Reback <jeff@reback.net>

Closes pandas-dev#15353 from jreback/stats and squashes the following commits:

9563740 [Jeff Reback] DEPR: remove statsmodels as a dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIGRATE: move stats code to statsmodels / deprecate in pandas
3 participants