PEP8: fix sql.py and test_sql.py #12263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it was failing the linting before but that was turned off until very recently to actually fail Travis I usually check these before I manually merge but didn't in this case |
cldy
pushed a commit
to cldy/pandas
that referenced
this pull request
Feb 11, 2016
Master is failing due to my PR pandas-dev#12205 Strange that it did not fail on travis before merging ? Author: Joris Van den Bossche <jorisvandenbossche@gmail.com> Closes pandas-dev#12263 from jorisvandenbossche/fix-sql-pep8 and squashes the following commits: f2c1606 [Joris Van den Bossche] PEP8: fix sql.py and test_sql.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master is failing due to my PR #12205
Strange that it did not fail on travis before merging ?