ENH: Python parser now accepts delim_whitespace=True #12958
Conversation
|
can you confirm with #12686 that all options are covered? |
|
I think doc-string and io.rst need small edits for this (to remove that this is only for c engine) |
|
I don't quite understand your question. Could you clarify? Ah, yes, good point. Need to change what I just added since it's supported for Python now! |
| @@ -2867,6 +2841,103 @@ def test_read_only_header_no_rows(self): | |||
| df = self.read_csv(StringIO('a,b,c'), index_col=False) | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
| def test_line_comment(self): | |||
There was a problem hiding this comment.
what is the net affect of moving all of these tests around?
There was a problem hiding this comment.
Better coverage. Now all of the engines are getting tested under all of the conditions for these delim_whitespace-related ones. The tests in general are arranged somewhat strangely, so at some point a refactor of the entire test suite will be needed, but not here of course 😄
|
I meant we are now listing all of the options in that issue so that we can check them off. And you have them listed in the variables to check for the options, just want a cross check. bonus points if you can autogenerate a section in the doc-string which explicity lists the unsupported options (by using those variables). Or maybe don't need to auto-generate, maybe just list a section in doc-string & io.rst to at least list the un-described / only certain engine supported options. |
|
Well, they used to be a copy of |
|
@gfyoung if you can post a correct list I will update |
|
FYI, Travis has just given the green light for my changes, so if you don't have any other code-related complaints, I'll update the documentation with |
as_recarray na_filter compact_ints use_unsigned low_memory memory_map buffer_lines error_bad_lines warn_bad_lines dtype decimal float_precision If any of these are non-default with a |
|
ok I edited the other issue, pls have a look |
|
Are those uncapitalised headers (e.g. "undocumented in C engine only") sub sections for "Features supported in the C engine only"? If not, all of the ones that I listed just now should also go under "Features supported in the C engine only" |
gfyoung
force-pushed
the
delim-whitespace-python
branch
2 times, most recently
from
c835a6a to
18c02f3
Compare
| @@ -101,8 +101,7 @@ delim_whitespace : boolean, default False | |||
| Specifies whether or not whitespace (e.g. ``' '`` or ``'\t'``) | |||
| will be used as the delimiter. Equivalent to setting ``sep='\+s'``. | |||
| If this option is set to True, nothing should be passed in for the | |||
| ``delimiter`` parameter. This parameter is currently supported for | |||
| the C parser only. | |||
| ``delimiter`` parameter. | |||
There was a problem hiding this comment.
add that this was added in 0.18.1
There was a problem hiding this comment.
@gfyoung if you can update this, and lmlk when you push.
gfyoung
force-pushed
the
delim-whitespace-python
branch
from
18c02f3 to
08da127
Compare
|
ty |
Title is self-explanatory.