Skip to content

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented Apr 26, 2016

xref #12996

@jreback jreback added Docs Datetime Datetime data dtype labels Apr 26, 2016
@jreback jreback added this to the 0.18.1 milestone Apr 26, 2016
@jreback
Copy link
Contributor Author

jreback commented Apr 26, 2016

@jorisvandenbossche

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this legit to do here?

@jreback
Copy link
Contributor Author

jreback commented Apr 26, 2016

also added #12974 fix here.

@jreback jreback closed this in ec9a399 Apr 27, 2016
@jorisvandenbossche
Copy link
Member

@jreback Can you please try to not change the commit too much during the merge? This makes reviewing PRs / seeing what has been merged a lot more difficult using github (as it seems the 'Files changed' is quite different from the actual merged commit).

(of course, small fixup changes are not a problem, certainly for PRs of other contributors to not have them endlessly adapt minor things)

@jreback
Copy link
Contributor Author

jreback commented Apr 27, 2016

@jorisvandenbossche I normally don't. but ended up going on a tangent with some other things (somewhat unrelated).

@jorisvandenbossche
Copy link
Member

That's OK! (I just noticed it for this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Datetime Datetime data dtype Docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants