-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
PERF: DataFrame transform #13192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
PERF: DataFrame transform #13192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes (unless it was deliberate?) the issue of |
Current coverage is 84.12%@@ master #13192 diff @@
==========================================
Files 138 138
Lines 50385 50382 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 42383 42381 -2
+ Misses 8002 8001 -1
Partials 0 0
|
out = self._try_cast(out, self._selected_obj) | ||
|
||
return Series(out, index=self.obj.index) | ||
counts = self.size().fillna(0).values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a big deal, but isn't this self.size().isnull().any()
?
thanks @chris-b1 very nice PR as usual! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Groupby
Performance
Memory or execution speed performance
Reshaping
Concat, Merge/Join, Stack/Unstack, Explode
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes BUG: Series _transform_fast fails for datetime with null groups #13191
git diff upstream/master | flake8 --diff