BUG: Properly validate and parse nrows in read_csv #13275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Number of rows of file to read. Useful for reading pieces of large files. | ||
| If ``nrows`` is a float, it must be castable to an integer without losing |
There was a problem hiding this comment.
you don't need to add that this accepts float
gfyoung
force-pushed
the
nrows-bug-validate
branch
2 times, most recently
from
c92d123 to
600c7c6
Compare
gfyoung
force-pushed
the
nrows-bug-validate
branch
from
600c7c6 to
d856051
Compare
|
@jreback : Made the requested changes, and Travis is still giving the green light. Ready to merge if there is nothing else. |
jreback
added
Error Reporting
|
short and sweet! nice! thanks @gfyoung |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
floatvalues fornrowsfor the Python enginenrowsargument for the CParser (e.g. you can passingnrows=1.2)Closes #10476.