Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add support for na_filter in Python engine #13321

Closed
wants to merge 1 commit into from
Closed

ENH: add support for na_filter in Python engine #13321

wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented May 29, 2016

Title is self-explanatory.

@gfyoung gfyoung force-pushed the python-engine-na-filter branch 2 times, most recently from c7c9a91 to 5cb0ae6 Compare May 30, 2016 01:26
@codecov-io
Copy link

codecov-io commented May 30, 2016 •
edited
Loading

Current coverage is 84.22%

Merging #13321 into master will increase coverage by <.01%

@@             master     #13321   diff @@
==========================================
  Files           138        138          
  Lines         50681      50670    -11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42682      42675     -7   
+ Misses         7999       7995     -4   
  Partials          0          0

Powered by Codecov. Last updated by 9e7bfdd...5cb0ae6

@jreback jreback added IO CSV read_csv, to_csv and removed IO CSV read_csv, to_csv labels May 30, 2016
@jreback jreback added this to the 0.18.2 milestone May 30, 2016
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label May 30, 2016
@jreback
Copy link
Contributor

jreback commented May 30, 2016

looks fine. pls rebase

@gfyoung gfyoung force-pushed the python-engine-na-filter branch 2 times, most recently from 3922595 to 7820c88 Compare May 30, 2016 21:54
@gfyoung gfyoung force-pushed the python-engine-na-filter branch from 7820c88 to 186fd34 Compare May 30, 2016 21:55
@gfyoung
Copy link
Member Author

gfyoung commented May 31, 2016

@jreback : Rebased and Travis is giving the green light. Ready to merge if there are no other concerns.

jorisvandenbossche
jorisvandenbossche reviewed May 31, 2016
View reviewed changes
doc/source/whatsnew/v0.18.2.txt
@@ -75,6 +75,7 @@ Other enhancements
pd.Timestamp(year=2012, month=1, day=1, hour=8, minute=30)

- The ``pd.read_csv()`` with ``engine='python'`` has gained support for the ``decimal`` option (:issue:`12933`)
- The ``pd.read_csv()`` with ``engine='python'`` has gained support for the ``na_filter`` option (:issue:`13321`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you combine this with the previous point in one sentence?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we leave separate issues on separate lines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that important! (and I don't know if we have a rule about it)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Unless there are more objections about this, I'll leave as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we try to have separate issue on separate lines that were closed by different PR's, but yes occasionally do bunch them up if they are repetitive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So...how about this one?

@jorisvandenbossche
Copy link
Member

@gfyoung very minor comment

@jreback jreback closed this in c0850ea May 31, 2016
@jreback
Copy link
Contributor

jreback commented May 31, 2016

ty @gfyoung

@kawochen kawochen mentioned this pull request May 31, 2016
Open
22 tasks
@gfyoung gfyoung deleted the python-engine-na-filter branch May 31, 2016 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions IO CSV read_csv, to_csv
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gfyoung @codecov-io @jreback @jorisvandenbossche